-
Couldn't load subscription status.
- Fork 3.4k
HBASE-27991 fixing ClassCastException in multithread client run #5346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
5a5cd04 to
9c73464
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
9c73464 to
c85a076
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
7388672 to
835ef6a
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thank you @nikita15p for raising you 1st PR in HBase. It would be great if you could give some context for others on how the change fixes the issue and/or why this change is needed. |
| } | ||
|
|
||
| // getRowCountFromTable takes table as input and return the number of rows | ||
| private static int getRowCountFromTable(Table t) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please replace this with org.apache.hadoop.hbase.HBaseTestingUtil#countRows(org.apache.hadoop.hbase.client.Table, org.apache.hadoop.hbase.client.Scan)
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
4fd696a to
0f0eb76
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
0f0eb76 to
f3147ff
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Hi @Apache9 I suspect https://issues.apache.org/jira/browse/HBASE-22244 / #155 might have broken compatibility on what can be passed to |
|
Overall the change in this PR looks good to me, if above concern is not an issue. Good catch @nikita15p :) |
|
I have been able to write a UT to confirm this. Raised https://issues.apache.org/jira/browse/HBASE-28035, raised a UT PR to demonstrate same at #5365 |
|
Gentle Reminder: @Apache9 can u please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean up and the test.
Since we have a JIRA for the issue which cause this class to fail, I am good with this change to go in as is. We can look at the issue which introduced this bug as part of HBASE-28035. +1 to this change. |
|
Thanks for making your 1st contribution in Apache HBase @nikita15p :) Also, could you please raise a backport PR for branch-2? Since the failure is only relevant for branch-2 as explained in #5365 (comment), so its worth getting this through jenkins in PR. |
…ang.ClassCastException (#5346) Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 75bcd3c)
…ang.ClassCastException (apache#5346) Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…ang.ClassCastException (#5346) (#5425) Co-authored-by: Nikita Pande <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…ang.ClassCastException (#5346) (#5425) Co-authored-by: Nikita Pande <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 8caebc3)
…ang.ClassCastException (#5346) (#5425) Co-authored-by: Nikita Pande <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 8caebc3)
…ang.ClassCastException (apache#5346) Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…ang.ClassCastException (apache#5346) (apache#5425) Co-authored-by: Nikita Pande <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 8caebc3) (cherry picked from commit ae7dc1d) Change-Id: I219fe1b66e224291193c0c41d72056e8004731c1
This PR is now open for review. The details os stack trace is captured in https://issues.apache.org/jira/projects/HBASE/issues/HBASE-27991
ForkJoinPool and ThreadPoolExecutor are both implemented classes of the ExecutorService interface from the java.util.concurrent package, which provides a framework for asynchronously executing tasks in Java.