Skip to content

HBASE-27927 Skip zero length bytes of WALKey and WALEntry cells to av… #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HBASE-27927 Skip zero length bytes of WALKey and WALEntry cells to av… #5301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...rver/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufWALTailingReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ private IOException unwrapIPBE(IOException e) {
private ReadWALKeyResult readWALKey(long originalPosition) {
int firstByte;
try {
firstByte = delegatingInput.read();
do {
firstByte = delegatingInput.read();
} while (firstByte == 0);
} catch (IOException e) {
LOG.warn("Failed to read wal key length first byte", e);
return KEY_ERROR_AND_RESET;
Expand Down
5 changes: 5 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,11 @@ public CompressedKvDecoder(InputStream in, CompressionContext compression) {

@Override
protected Cell parseCell() throws IOException {
int firstByte = in.read();
while (firstByte == 0) {
firstByte = in.read();
}
((PBIS) in).unread(firstByte);
int keylength = StreamUtils.readRawVarint32(in);
int vlength = StreamUtils.readRawVarint32(in);
int tagsLength = StreamUtils.readRawVarint32(in);
Expand Down