HBASE-27799: RpcThrottlingException wait interval message is misleading between 0-1s #5192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
rmdmattingly
force-pushed
the
HBASE-27799
branch
from
6004e21 to
fec0eda
Compare
bbeaudreault
approved these changes
Apr 19, 2023
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thank you! I think those first failures are because I force pushed a change |
bbeaudreault
requested changes
Apr 20, 2023
|
|
||
| private static String stringFromMillis(long millis) { | ||
| if (millis >= 1000) { | ||
| return StringUtils.formatTime(millis); |
There was a problem hiding this comment.
Actually, I realize this will continue to be misleading for values greater than 1s. For example 1.9s is almost double what would be shown by formatTime. It matters less for values in the 10s of seconds or higher, but I think it will be very common to have values mostly in the single digit seconds.
We could copy the impl of formatTime here and add ms, or use the existing formatTime and append a ms part, or look for a different "humanize" method/library (as long as it's already a dep)
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@rmdmattingly can you fix the javac warnings? |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
approved these changes
Apr 22, 2023
|
i dont have time to handle merging right now, but will try to do it in the next couple days. thanks! |
|
@bbeaudreault while working on https://issues.apache.org/jira/browse/HBASE-27798 I realized that there's an extra change that I want to make here. These changes would break Though notably, |
rmdmattingly
commented
Apr 26, 2023
Comment on lines
176
to
190
| if (i == 1) { | ||
| time += Math.round(Float.parseFloat(m.group(1)) * 1000); // sec | ||
| time += Math.round(Float.parseFloat(m.group(2))); // ms | ||
| } | ||
| if (i == 2) { | ||
| time += Math.round(Float.parseFloat(m.group(1)) * 60 * 1000); // mins | ||
| time += Math.round(Float.parseFloat(m.group(2)) * 1000); // sec | ||
| time += Math.round(Float.parseFloat(m.group(3))); // ms | ||
| } | ||
| if (i == 3) { | ||
| time += Math.round(Float.parseFloat(m.group(1)) * 60 * 60 * 1000); // hrs | ||
| time += Math.round(Float.parseFloat(m.group(2)) * 60 * 1000); // mins | ||
| time += Math.round(Float.parseFloat(m.group(3)) * 1000); // sec | ||
| time += Math.round(Float.parseFloat(m.group(4))); // ms | ||
| } |
There was a problem hiding this comment.
admittedly we could clean this up a bit via some sort of loop, but I think the initial implementation suffered from trying to be a little too clever and this both works and is straightforward imo
| HBaseClassTestRule.forClass(TestRpcThrottlingException.class); | ||
|
|
||
| @Test | ||
| public void itHandlesSecWaitIntervalMessage() { |
There was a problem hiding this comment.
We should also test that it still works for the old format. We need to make sure it doesn't break if someone deploys the updated client side with old servers or vice versa.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
rmdmattingly
commented
Apr 26, 2023
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
reviewed
May 1, 2023
hbase-client/src/test/java/org/apache/hadoop/hbase/quotas/TestRpcThrottlingException.java
Outdated
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java
Outdated
Show resolved
Hide resolved
bbeaudreault
reviewed
May 1, 2023
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
reviewed
May 3, 2023
hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/RpcThrottlingException.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
pushed a commit
that referenced
this pull request
May 4, 2023
…ng between 0-1s (#5192) Signed-off-by: Bryan Beaudreault <[email protected]>
bbeaudreault
pushed a commit
that referenced
this pull request
May 4, 2023
…ng between 0-1s (#5192) Signed-off-by: Bryan Beaudreault <[email protected]>
bbeaudreault
pushed a commit
that referenced
this pull request
May 4, 2023
…ng between 0-1s (#5192) Signed-off-by: Bryan Beaudreault <[email protected]>
rmdmattingly
added a commit
to HubSpot/hbase
that referenced
this pull request
May 4, 2023
…ng between 0-1s (apache#5192) Signed-off-by: Bryan Beaudreault <[email protected]>
rmdmattingly
added a commit
to HubSpot/hbase
that referenced
this pull request
May 5, 2023
…ng between 0-1s (apache#5192) (#52) Signed-off-by: Bryan Beaudreault <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…ng between 0-1s (apache#5192) Signed-off-by: Bryan Beaudreault <[email protected]> (cherry picked from commit 05de158) Change-Id: Ic2755a64fa017d56a77e42355266af5b615d0f40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringUtils#formatTimewill round down millis which can produce misleading error messages on RpcThrottlingExceptions with wait intervals between 0 and 1 second. This PR simply adds support expressing sub-second wait intervals@bbeaudreault