Skip to content

Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2 #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Backport "HBASE-27708 CPU hot-spot resolving User subject" to branch-2 #5111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions hbase-common/src/main/java/org/apache/hadoop/hbase/security/User.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,20 +270,28 @@ public static boolean shouldLoginFromKeytab(Configuration conf) {
public static final class SecureHadoopUser extends User {
private String shortName;
private LoadingCache<String, String[]> cache;
/**
* Cache value of this instance's {@link #toString()} value. Computing this value is expensive.
* Assumes the UGI is never updated. See HBASE-27708.
*/
private final String toString;

public SecureHadoopUser() throws IOException {
ugi = UserGroupInformation.getCurrentUser();
this.cache = null;
this.toString = ugi.toString();
}

public SecureHadoopUser(UserGroupInformation ugi) {
this.ugi = ugi;
this.cache = null;
this.toString = ugi.toString();
}

public SecureHadoopUser(UserGroupInformation ugi, LoadingCache<String, String[]> cache) {
this.ugi = ugi;
this.cache = cache;
this.toString = ugi.toString();
}

@Override
Expand Down Expand Up @@ -320,6 +328,11 @@ public <T> T runAs(PrivilegedExceptionAction<T> action)
return ugi.doAs(action);
}

@Override
public String toString() {
return toString;
}

/**
* Create a user for testing.
* @see User#createUserForTesting(org.apache.hadoop.conf.Configuration, String, String[])
Expand Down