HBASE-27579 CatalogJanitor can cause data loss due to errors during cleanMergeRegion #4986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
apurtell
approved these changes
Jan 19, 2023
virajjasani
reviewed
Jan 19, 2023
Comment on lines
+416
to
418
| LOG.error("Error trying to determine if region exists, assuming exists and has references", | ||
| ioe); | ||
| return new Pair<>(Boolean.TRUE, Boolean.TRUE); |
There was a problem hiding this comment.
So this is the big difference b/ the two implementations right?
There was a problem hiding this comment.
Correct. Previously we'd treat this error as "lets assume it doesn't exist and go forward with cleanup". This assumption was inaccurate in at least some failure modes, so unsafe. The new assumption is "we don't know if the region exists, so let's not risk cleaning up". This is safer, but the downside is we might wait longer to GC merged regions. I think that's not a problem at all.
There was a problem hiding this comment.
This is safer, but the downside is we might wait longer to GC merged regions. I think that's not a problem at all.
+1
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Jan 19, 2023
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Jan 20, 2023
|
Thanks all for the review. Having trouble with some flaky tests. I'm going to let it run once more to see if we can get a clean build. So far I've run the failing tests manually and they succeed locally. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
added a commit
that referenced
this pull request
Jan 20, 2023
…leanMergeRegion (#4986) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
bbeaudreault
added a commit
that referenced
this pull request
Jan 20, 2023
…leanMergeRegion (#4986) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
bbeaudreault
added a commit
that referenced
this pull request
Jan 20, 2023
…leanMergeRegion (#4986) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
bbeaudreault
added a commit
to HubSpot/hbase
that referenced
this pull request
Jan 20, 2023
…leanMergeRegion (apache#4986) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…leanMergeRegion (apache#4986) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit a7f776f) Change-Id: I19696f331e463024e4205036c95a09a5aab75816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There already existed a robust reference check method for cleaning splits,
checkDaughterInFs. I cleaned that up a little bit and re-use it in cleanMergeRegion. This way both cleaning splits and merges use the same reference checking logic. This should be easier to maintain going forward.I added tests in TestCatalogJanitor -- there were none for merges, so i added a base case and a failure mode case.
I decided not to modify HRegionFileSystem.openRegionFromFileSystem -- even if I modified that to throw FileNotFoundException, from a defensive coding perspective I'd rather not assume that exception refers to the region dir specifically. This code is highly destructive, so we rely on an explicit
existscall and only delete if that successfully returns false within our method.