Skip to content

Revert "Backport "HBASE-27563 ChaosMonkey sometimes generates invalid boundaries for random item selection" to branch-2.4" #4964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Revert "Backport "HBASE-27563 ChaosMonkey sometimes generates invalid boundaries for random item selection" to branch-2.4" #4964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 6 additions & 31 deletions hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/monkies/PolicyBasedChaosMonkey.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
*/
package org.apache.hadoop.hbase.chaos.monkies;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
Expand All @@ -31,16 +30,13 @@
import org.apache.hadoop.hbase.IntegrationTestingUtility;
import org.apache.hadoop.hbase.chaos.policies.Policy;
import org.apache.hadoop.hbase.util.Pair;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;

/**
* Chaos monkey that given multiple policies will run actions against the cluster.
*/
public class PolicyBasedChaosMonkey extends ChaosMonkey {
private static final Logger LOG = LoggerFactory.getLogger(PolicyBasedChaosMonkey.class);

private static final long ONE_SEC = 1000;
private static final long ONE_MIN = 60 * ONE_SEC;
Expand Down Expand Up @@ -120,31 +116,13 @@ public static <T> T selectWeightedRandomItem(List<Pair<T, Integer>> items) {

/** Selects and returns ceil(ratio * items.length) random items from the given array */
public static <T> List<T> selectRandomItems(T[] items, float ratio) {
/*
* N.b. `ratio` values are not validated. Be aware of excessive values and floating point
* arithmetic rounding. Guard against negative input to Random#next() and exceeding boundaries
* in call to List#subList.
*/
int selectedNumber = (int) Math.ceil(items.length * ratio);

// clamp ratio to [0.0,1.0]
ratio = Math.max(Math.min(ratio, 1.0f), 0.0f);
List<T> originalItems = Arrays.asList(items);
Collections.shuffle(originalItems);

final int selectedNumber = (int) Math.ceil(items.length * ratio);

// shuffle a copy of the input, not the input.
final List<T> shuffledItems = new ArrayList<>(items.length);
shuffledItems.addAll(Arrays.asList(items));
Collections.shuffle(shuffledItems);

if (selectedNumber >= items.length) {
return shuffledItems;
}

// apply basic sanity check on sublist selection range.
final int startIndex =
Math.max(0, ThreadLocalRandom.current().nextInt(items.length - selectedNumber));
final int endIndex = Math.min(items.length, startIndex + selectedNumber);
return shuffledItems.subList(startIndex, endIndex);
int startIndex = ThreadLocalRandom.current().nextInt(items.length - selectedNumber);
return originalItems.subList(startIndex, startIndex + selectedNumber);
}

@Override
Expand Down Expand Up @@ -173,10 +151,7 @@ public boolean isStopped() {

@Override
public void waitForStop() throws InterruptedException {
if (!monkeyThreadPool.awaitTermination(1, TimeUnit.MINUTES)) {
LOG.warn("Some pool threads failed to terminate. Forcing. {}", monkeyThreadPool);
monkeyThreadPool.shutdownNow();
}
monkeyThreadPool.awaitTermination(1, TimeUnit.MINUTES);
}

@Override
Expand Down