Skip to content

When a huge amount of data writing to hbase through thrift2, there wi… #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

When a huge amount of data writing to hbase through thrift2, there wi… #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;

import com.google.common.cache.RemovalListener;
import com.google.common.cache.RemovalNotification;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.hbase.classification.InterfaceAudience;
Expand All @@ -49,6 +51,7 @@
import org.apache.hadoop.hbase.thrift2.generated.*;
import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.ConnectionCache;
import org.apache.thrift.TBaseHelper;
import org.apache.thrift.TException;

import com.google.common.cache.Cache;
Expand Down Expand Up @@ -116,10 +119,14 @@ private static long now() {
return System.nanoTime();
}

ThriftHBaseServiceHandler(Configuration conf, UserProvider userProvider) throws IOException
{
this(conf, userProvider, conf.getInt(MAX_IDLETIME, 10 * 60 * 1000));
}

ThriftHBaseServiceHandler(final Configuration conf,
final UserProvider userProvider) throws IOException {
final UserProvider userProvider, int maxIdleTime) throws IOException {
int cleanInterval = conf.getInt(CLEANUP_INTERVAL, 10 * 1000);
int maxIdleTime = conf.getInt(MAX_IDLETIME, 10 * 60 * 1000);
connectionCache = new ConnectionCache(
conf, userProvider, cleanInterval, maxIdleTime);
tableFactory = new HTableFactory() {
Expand All @@ -133,8 +140,20 @@ public HTableInterface createHTableInterface(Configuration config,
}
}
};
RemovalListener<String, HTablePool> removalListener = new RemovalListener<String, HTablePool>() {
@Override
public void onRemoval(RemovalNotification<String, HTablePool> removal){
HTablePool pool = (HTablePool)removal.getValue();
try {
pool.close();
} catch (IOException ex) {
ThriftHBaseServiceHandler.LOG.error("Failed to close HTablePool for user=" + (String)removal.getKey(), ex);
}
}
};

htablePools = CacheBuilder.newBuilder().expireAfterAccess(
maxIdleTime, TimeUnit.MILLISECONDS).softValues().concurrencyLevel(4).build();
maxIdleTime, TimeUnit.MILLISECONDS).removalListener(removalListener).softValues().concurrencyLevel(4).build();
maxPoolSize = conf.getInt("hbase.thrift.htablepool.size.max", 1000);
htablePoolCreater = new Callable<HTablePool>() {
public HTablePool call() {
Expand All @@ -143,7 +162,16 @@ public HTablePool call() {
};
}

public void refreshConnection(String tableName) throws IOException {
this.connectionCache.getTable(tableName);
}

private HTableInterface getTable(ByteBuffer tableName) {
try {
refreshConnection(Bytes.toString(TBaseHelper.byteBufferToByteArray(tableName)));
} catch (IOException ex) {
LOG.warn("Failed to refresh connection cache.", ex);
}
String currentUser = connectionCache.getEffectiveUser();
try {
HTablePool htablePool = htablePools.get(currentUser, htablePoolCreater);
Expand Down