HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled #4868

wchevreuil · 2022-11-08T21:06:08Z

No description provided.

…ks if compaction is enabled Change-Id: I63296f5f95c9549d75ea7c991d2202c2e550300e

Apache-HBase · 2022-11-08T21:53:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	3m 42s	master passed
+1 💚	checkstyle	1m 2s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	4m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	3m 38s	the patch passed
+1 💚	cc	3m 38s	the patch passed
+1 💚	javac	3m 38s	the patch passed
-0 ⚠️	checkstyle	0m 16s	hbase-client: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
-0 ⚠️	checkstyle	0m 36s	hbase-server: The patch generated 15 new + 28 unchanged - 0 fixed = 43 total (was 28)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 49s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	hbaseprotoc	1m 23s	the patch passed
-1 ❌	spotless	0m 18s	patch has 30 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	4m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		42m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname	Linux 6bd7b6919975 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `41c7bd3`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I7b43530fe2ba44e6b6eb21f6526f7120a8eb235b

Change-Id: Ia6bcfcb9445e4a448073474d12bda549cf5c6edd

Apache-HBase · 2022-11-09T12:44:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	3m 39s	master passed
+1 💚	checkstyle	1m 1s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	4m 22s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	3m 38s	the patch passed
+1 💚	cc	3m 38s	the patch passed
+1 💚	javac	3m 38s	the patch passed
+1 💚	checkstyle	0m 59s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 57s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	hbaseprotoc	1m 22s	the patch passed
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	4m 42s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		43m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname	Linux e80b49eb17a4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `41c7bd3`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/CloseRegionProcedure.java

...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java

Apache9 · 2022-11-12T14:30:10Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java

    HRegion region = null;
+    boolean compactionEnabled =
+      ((HRegionServer) server).getCompactSplitThread().isCompactionsEnabled();
+    this.server.getConfiguration().setBoolean(HBASE_REGION_SERVER_ENABLE_COMPACTION,


Why change the global configuration here?

We want to prefetch blocks for links/refs only if compaction is disabled, but the prefetch happens in the HFileReader, where we don't access to the CompactSplitThread, so saving the state of compaction switch in the config for HFileReader deciding if prefetch should go ahead.

...server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/UnassignRegionHandler.java

Apache-HBase · 2022-11-26T16:43:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	3m 36s	master passed
+1 💚	checkstyle	0m 59s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	4m 20s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	3m 39s	the patch passed
+1 💚	cc	3m 39s	the patch passed
+1 💚	javac	3m 39s	the patch passed
-0 ⚠️	checkstyle	0m 34s	hbase-server: The patch generated 2 new + 28 unchanged - 0 fixed = 30 total (was 28)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 50s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	hbaseprotoc	1m 22s	the patch passed
-1 ❌	spotless	0m 35s	patch has 65 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	4m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		43m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname	Linux cbdde032405a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a5ff289`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-26T19:35:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	master passed
+1 💚	compile	1m 27s	master passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 23s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	3m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
+1 💚	unit	191m 5s	hbase-server in the patch passed.
		215m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b832dab41f5a 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a5ff289`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/testReport/
Max. process+thread count	2653 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-26T20:01:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 13s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	3m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 1s	hbase-client in the patch passed.
+1 💚	unit	215m 31s	hbase-server in the patch passed.
		240m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e3e12fc4aaee 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a5ff289`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/testReport/
Max. process+thread count	2544 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-28T13:23:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	3m 40s	master passed
+1 💚	checkstyle	1m 0s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	4m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	3m 38s	the patch passed
+1 💚	cc	3m 38s	the patch passed
+1 💚	javac	3m 38s	the patch passed
+1 💚	checkstyle	0m 58s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 48s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	hbaseprotoc	1m 24s	the patch passed
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	4m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		42m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname	Linux 4e6c641742b8 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bb9f43c`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-28T16:33:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 41s	master passed
+1 💚	compile	1m 43s	master passed
+1 💚	shadedjars	3m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	1m 47s	the patch passed
+1 💚	javac	1m 47s	the patch passed
+1 💚	shadedjars	3m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	207m 0s	hbase-server in the patch passed.
		232m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d480ef7bb2bb 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bb9f43c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/testReport/
Max. process+thread count	2435 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-28T17:29:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	1m 46s	master passed
+1 💚	shadedjars	4m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	1m 40s	the patch passed
+1 💚	javac	1m 40s	the patch passed
+1 💚	shadedjars	4m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 16s	hbase-client in the patch passed.
-1 ❌	unit	259m 46s	hbase-server in the patch failed.
		289m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4868
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dcde3c55039e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bb9f43c`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/testReport/
Max. process+thread count	2444 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4868/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil · 2022-12-01T14:24:54Z

Latest test failure shouldn't be related.

wchevreuil · 2022-12-01T14:26:12Z

recheck

petersomogyi

The change looks fine. I had some thoughts on compatibility related to upgrade/rollback but I don't think those could be affected.

…ks if compaction is enabled (#4868) Signed-off-by: Peter Somogyi <[email protected]> (cherry picked from commit 222ec68)

…ks if compaction is enabled (apache#4868) Signed-off-by: Peter Somogyi <[email protected]>

…aching reference/hlinks if compaction is enabled (apache#4868) Signed-off-by: Peter Somogyi <[email protected]> (cherry picked from commit 222ec68) Change-Id: I0d864cbd2a423e8df27e964834c2bcee21a532f9

HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlin…

f24615d

…ks if compaction is enabled Change-Id: I63296f5f95c9549d75ea7c991d2202c2e550300e

Wellington Chevreuil added 2 commits November 9, 2022 11:42

checkstyles

4ee9264

Change-Id: I7b43530fe2ba44e6b6eb21f6526f7120a8eb235b

spotless

525137f

Change-Id: Ia6bcfcb9445e4a448073474d12bda549cf5c6edd

wchevreuil requested review from Apache9, ankitsinghal and taklwu November 11, 2022 11:18

Apache9 reviewed Nov 12, 2022

View reviewed changes

wchevreuil added 2 commits November 26, 2022 15:47

removing optionals; adding extra field serialization on procs;

0367419

master proto changes

e690557

wchevreuil requested a review from Apache9 November 26, 2022 15:59

spotless fixes

32114b4

wchevreuil requested a review from petersomogyi December 1, 2022 11:01

petersomogyi approved these changes Dec 9, 2022

View reviewed changes

wchevreuil merged commit 222ec68 into apache:master Dec 16, 2022

wchevreuil added a commit that referenced this pull request Dec 19, 2022

HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlin…

012306b

…ks if compaction is enabled (#4868) Signed-off-by: Peter Somogyi <[email protected]> (cherry picked from commit 222ec68)

virajjasani pushed a commit to virajjasani/hbase that referenced this pull request Jan 5, 2023

HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlin…

01d9e80

…ks if compaction is enabled (apache#4868) Signed-off-by: Peter Somogyi <[email protected]>

Uh oh!

HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled #4868

HBASE-27474 Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled #4868

Uh oh!

Conversation

wchevreuil commented Nov 8, 2022

Uh oh!

Apache-HBase commented Nov 8, 2022

Uh oh!

Apache-HBase commented Nov 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache9 Nov 12, 2022

Choose a reason for hiding this comment

Uh oh!

wchevreuil Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 26, 2022

Uh oh!

Apache-HBase commented Nov 28, 2022

Uh oh!

Apache-HBase commented Nov 28, 2022

Uh oh!

Apache-HBase commented Nov 28, 2022

Uh oh!

wchevreuil commented Dec 1, 2022

Uh oh!

wchevreuil commented Dec 1, 2022

Uh oh!

petersomogyi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants