Skip to content

HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2022
Merged

HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables #4849

merged 3 commits into from
Nov 5, 2022

Conversation

@2005hithlj
Copy link
Contributor

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 21s master passed
+1 💚 compile 4m 46s master passed
+1 💚 checkstyle 1m 27s master passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 18s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 12s the patch passed
+1 💚 compile 4m 51s the patch passed
+1 💚 cc 4m 51s the patch passed
+1 💚 javac 4m 51s the patch passed
+1 💚 checkstyle 1m 24s the patch passed
-0 ⚠️ rubocop 0m 6s The patch generated 6 new + 427 unchanged - 0 fixed = 433 total (was 427)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 52s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 hbaseprotoc 1m 55s the patch passed
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 45s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
47m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4849
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux ba05ac4858c7 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5e251c4
Default Java Temurin-1.8.0_345-b01
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.7.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 18s master passed
+1 💚 compile 2m 2s master passed
+1 💚 shadedjars 3m 47s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 25s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 9s the patch passed
+1 💚 compile 2m 1s the patch passed
+1 💚 javac 2m 1s the patch passed
+1 💚 shadedjars 3m 47s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 22s the patch passed
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 13s hbase-client in the patch passed.
-1 ❌ unit 219m 8s hbase-server in the patch failed.
+1 💚 unit 8m 37s hbase-thrift in the patch passed.
+1 💚 unit 7m 44s hbase-shell in the patch passed.
260m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4849
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3ee934004731 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5e251c4
Default Java Temurin-1.8.0_345-b01
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/testReport/
Max. process+thread count 2903 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to add a method to list enabled or disabled tables, just a flag to indicate enabled or disabled table? And also better add a method for listing table descriptors?

@2005hithlj 2005hithlj closed this Oct 28, 2022
@2005hithlj 2005hithlj reopened this Oct 28, 2022
@2005hithlj
Copy link
Contributor Author

Is it better to add a method to list enabled or disabled tables, just a flag to indicate enabled or disabled table? And also better add a method for listing table descriptors?

@Apache9 sir. Thanks for your review, I will have a new commit.

@2005hithlj 2005hithlj changed the title HBASE-27444 Add a tool command list_disabled_tables HBASE-27444 Add tool commands list_enabled_tables and list_disabled_tables Oct 31, 2022
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 19s master passed
+1 💚 compile 4m 26s master passed
+1 💚 checkstyle 1m 15s master passed
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
+1 💚 spotbugs 4m 59s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 25s the patch passed
+1 💚 compile 5m 1s the patch passed
+1 💚 cc 5m 1s the patch passed
+1 💚 javac 5m 1s the patch passed
-0 ⚠️ checkstyle 0m 15s hbase-client: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
-0 ⚠️ rubocop 0m 17s The patch generated 9 new + 427 unchanged - 0 fixed = 436 total (was 427)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 8m 28s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 hbaseprotoc 1m 46s the patch passed
+1 💚 spotless 0m 37s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 39s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
46m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4849
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux ea4720d9ffbb 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dc4fa05
Default Java Temurin-1.8.0_345-b01
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.7.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 14s master passed
+1 💚 compile 2m 22s master passed
+1 💚 shadedjars 3m 51s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 43s the patch passed
+1 💚 compile 2m 40s the patch passed
+1 💚 javac 2m 40s the patch passed
+1 💚 shadedjars 4m 1s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 36s the patch passed
_ Other Tests _
+1 💚 unit 0m 38s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 31s hbase-client in the patch passed.
+1 💚 unit 204m 14s hbase-server in the patch passed.
+1 💚 unit 7m 4s hbase-thrift in the patch passed.
+1 💚 unit 6m 53s hbase-shell in the patch passed.
245m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4849
Optional Tests javac javadoc unit shadedjars compile
uname Linux e68202ea112a 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dc4fa05
Default Java Eclipse Adoptium-11.0.16.1+1
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/testReport/
Max. process+thread count 2715 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj
Copy link
Contributor Author

@Apache9 sir. Could you take a look? Thanks.

Apache9
Apache9 reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No shell tests?

@2005hithlj
Copy link
Contributor Author

No shell tests?

@Apache9 sir, I have added shell tests.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 19s master passed
+1 💚 compile 4m 22s master passed
+1 💚 checkstyle 1m 15s master passed
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
+1 💚 spotbugs 4m 59s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 2m 7s the patch passed
+1 💚 compile 4m 26s the patch passed
+1 💚 cc 4m 26s the patch passed
+1 💚 javac 4m 26s the patch passed
-0 ⚠️ checkstyle 0m 12s hbase-client: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
-0 ⚠️ rubocop 0m 10s The patch generated 17 new + 431 unchanged - 0 fixed = 448 total (was 431)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 58s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 hbaseprotoc 1m 33s the patch passed
+1 💚 spotless 0m 36s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 27s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
47m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4849
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux fb4e1d30a201 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3f17745
Default Java Temurin-1.8.0_352-b08
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 69 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 28s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 2m 28s master passed
+1 💚 compile 2m 20s master passed
+1 💚 shadedjars 3m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 32s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 2m 21s the patch passed
+1 💚 javac 2m 21s the patch passed
+1 💚 shadedjars 3m 49s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 33s the patch passed
_ Other Tests _
+1 💚 unit 0m 37s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 30s hbase-client in the patch passed.
-1 ❌ unit 204m 39s hbase-server in the patch failed.
+1 💚 unit 6m 58s hbase-thrift in the patch passed.
-1 ❌ unit 7m 8s hbase-shell in the patch failed.
249m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4849
Optional Tests javac javadoc unit shadedjars compile
uname Linux b617b2f0efda 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3f17745
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/testReport/
Max. process+thread count 3111 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 49s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 2m 16s master passed
+1 💚 compile 2m 2s master passed
+1 💚 shadedjars 3m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 20s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 14s the patch passed
+1 💚 compile 2m 4s the patch passed
+1 💚 javac 2m 4s the patch passed
+1 💚 shadedjars 3m 48s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s the patch passed
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 11s hbase-client in the patch passed.
+1 💚 unit 216m 14s hbase-server in the patch passed.
+1 💚 unit 8m 33s hbase-thrift in the patch passed.
-1 ❌ unit 7m 43s hbase-shell in the patch failed.
264m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4849
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5585032ab40a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3f17745
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/testReport/
Max. process+thread count 2278 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj
Copy link
Contributor Author

The failed UTs of hbase-server/hbase-shell seems to have nothing to do with my code modification.

@Apache9
Copy link
Contributor

Apache9 commented Nov 1, 2022

Please check the failure UT for hbase-shell?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 19s master passed
+1 💚 compile 4m 25s master passed
+1 💚 checkstyle 1m 14s master passed
+1 💚 spotless 0m 38s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 3s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 4s the patch passed
+1 💚 compile 4m 29s the patch passed
+1 💚 cc 4m 29s the patch passed
+1 💚 javac 4m 29s the patch passed
-0 ⚠️ checkstyle 0m 12s hbase-client: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)
-0 ⚠️ rubocop 0m 10s The patch generated 17 new + 431 unchanged - 0 fixed = 448 total (was 431)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 8m 0s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 hbaseprotoc 1m 33s the patch passed
+1 💚 spotless 0m 37s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
44m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4849
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 65e167dfbcae 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3f17745
Default Java Temurin-1.8.0_352-b08
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 23s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 32s master passed
+1 💚 compile 2m 19s master passed
+1 💚 shadedjars 3m 49s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 33s the patch passed
+1 💚 compile 2m 21s the patch passed
+1 💚 javac 2m 21s the patch passed
+1 💚 shadedjars 3m 48s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 32s the patch passed
_ Other Tests _
+1 💚 unit 0m 37s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 30s hbase-client in the patch passed.
+1 💚 unit 203m 40s hbase-server in the patch passed.
+1 💚 unit 7m 5s hbase-thrift in the patch passed.
+1 💚 unit 6m 53s hbase-shell in the patch passed.
246m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4849
Optional Tests javac javadoc unit shadedjars compile
uname Linux cc9f46b5a4a9 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3f17745
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/testReport/
Max. process+thread count 3217 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 30s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 28s master passed
+1 💚 compile 2m 7s master passed
+1 💚 shadedjars 3m 50s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 8s the patch passed
+1 💚 compile 2m 3s the patch passed
+1 💚 javac 2m 3s the patch passed
+1 💚 shadedjars 3m 46s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 20s the patch passed
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 12s hbase-client in the patch passed.
+1 💚 unit 216m 28s hbase-server in the patch passed.
+1 💚 unit 8m 33s hbase-thrift in the patch passed.
+1 💚 unit 7m 46s hbase-shell in the patch passed.
261m 7s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4849
Optional Tests javac javadoc unit shadedjars compile
uname Linux a71b28fbbcb4 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3f17745
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/testReport/
Max. process+thread count 2632 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4849/4/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj
Copy link
Contributor Author

Please check the failure UT for hbase-shell?

@Apache9 sir.
I have modified the shell UT code, and the UTs are successfully executed in the new commit.

Apache9
Apache9 approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9 Apache9 merged commit 186679f into apache:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@2005hithlj @Apache-HBase @Apache9