Skip to content

HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2019
Merged

HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f… #484

merged 4 commits into from
Aug 23, 2019

Conversation

@eomiks
Copy link
Contributor

@eomiks eomiks commented Aug 13, 2019 •
edited
Loading

HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)

Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError of scan order check.

which is resolved by HBASE-19863 for 1.4, 2.x, or later version.

A same bug exists in branch 1.3 and older, and also my cluster suffered from the same problem.

When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
actual hfs offset can be behind, in this case heap.next() is not enough. it requires reseek to find right next cell.

java.lang.AssertionError: Key key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 
followed by a smaller key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at 
org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969) at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551) at 
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144) at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307) at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081) 
at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755) at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957) at 
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168)

I created a backport patch of HBASE-19863 and a part of HBASE-17958.

Exact same testcase included. And changed StoreScanner due to the difference of codes.

@eomiks
HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
47d2667 
…ilter could throw AssertionError (backport of HBASE-19863)
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 86 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 433 branch-1.3 passed
+1 compile 41 branch-1.3 passed
+1 checkstyle 112 branch-1.3 passed
-1 shadedjars 12 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 39 branch-1.3 passed
0 spotbugs 147 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 144 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 108 the patch passed
+1 compile 43 the patch passed
+1 javac 43 the patch passed
-1 checkstyle 104 hbase-server: The patch generated 4 new + 371 unchanged - 24 fixed = 375 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 10 patch has 10 errors when building our shaded downstream artifacts.
+1 hadoopcheck 655 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 38 the patch passed
+1 findbugs 160 the patch passed
_ Other Tests _
-1 unit 8170 hbase-server in the patch failed.
+1 asflicense 25 The patch does not generate ASF License warnings.
10278
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestScannerHeartbeatMessages
hadoop.hbase.regionserver.TestCompactSplitThread
hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
hadoop.hbase.client.TestAdmin2
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0b9b50f3ca6e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / 8e5e868
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/branch-shadedjars.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/testReport/
Max. process+thread count 4339 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@eomiks
HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
40d3593 
…ilter could throw AssertionError (backport of HBASE-19863)

+ checkstyle adapted.
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 47 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 435 branch-1.3 passed
+1 compile 36 branch-1.3 passed with JDK v1.8.0_222
+1 compile 39 branch-1.3 passed with JDK v1.7.0_232
+1 checkstyle 98 branch-1.3 passed
+1 shadedjars 150 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 35 branch-1.3 passed with JDK v1.8.0_222
+1 javadoc 36 branch-1.3 passed with JDK v1.7.0_232
0 spotbugs 168 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 165 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 99 the patch passed
+1 compile 38 the patch passed with JDK v1.8.0_222
+1 javac 38 the patch passed
+1 compile 40 the patch passed with JDK v1.7.0_232
+1 javac 40 the patch passed
-1 checkstyle 86 hbase-server: The patch generated 4 new + 371 unchanged - 24 fixed = 375 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 144 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 537 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 28 the patch passed with JDK v1.8.0_222
+1 javadoc 36 the patch passed with JDK v1.7.0_232
+1 findbugs 161 the patch passed
_ Other Tests _
+1 unit 5647 hbase-server in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
7970
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 9837e6ce7dd8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / 18c5abe
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/artifact/out/diff-checkstyle-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/testReport/
Max. process+thread count 3820 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 953 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 443 branch-1.3 passed
+1 compile 38 branch-1.3 passed with JDK v1.8.0_222
+1 compile 43 branch-1.3 passed with JDK v1.7.0_232
+1 checkstyle 105 branch-1.3 passed
+1 shadedjars 169 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 37 branch-1.3 passed with JDK v1.8.0_222
+1 javadoc 42 branch-1.3 passed with JDK v1.7.0_232
0 spotbugs 178 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 175 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 114 the patch passed
+1 compile 42 the patch passed with JDK v1.8.0_222
+1 javac 42 the patch passed
+1 compile 44 the patch passed with JDK v1.7.0_232
+1 javac 44 the patch passed
-1 checkstyle 97 hbase-server: The patch generated 1 new + 372 unchanged - 23 fixed = 373 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 158 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 580 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 30 the patch passed with JDK v1.8.0_222
+1 javadoc 44 the patch passed with JDK v1.7.0_232
+1 findbugs 179 the patch passed
_ Other Tests _
-1 unit 5856 hbase-server in the patch failed.
+1 asflicense 21 The patch does not generate ASF License warnings.
9270
Reason Tests
Failed junit tests hadoop.hbase.util.TestHBaseFsck
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 487830f1ae51 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / 18c5abe
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/testReport/
Max. process+thread count 3996 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/3/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@eomiks
HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
896b6f3 
…ilter could throw AssertionError (backport of HBASE-19863)

+ checkstyle adapted.
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1556 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 437 branch-1.3 passed
+1 compile 42 branch-1.3 passed
+1 checkstyle 116 branch-1.3 passed
-1 shadedjars 13 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 40 branch-1.3 passed
0 spotbugs 156 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 153 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 110 the patch passed
+1 compile 43 the patch passed
+1 javac 43 the patch passed
-1 checkstyle 111 hbase-server: The patch generated 1 new + 372 unchanged - 23 fixed = 373 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 11 patch has 10 errors when building our shaded downstream artifacts.
+1 hadoopcheck 585 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 30 the patch passed
+1 findbugs 262 the patch passed
_ Other Tests _
-1 unit 9089 hbase-server in the patch failed.
+1 asflicense 133 The patch does not generate ASF License warnings.
12912
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestEncryptionKeyRotation
hadoop.hbase.regionserver.TestRegionReplicas
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a112393a1bb9 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / d2b310b
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/branch-shadedjars.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/testReport/
Max. process+thread count 3809 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/4/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 55 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 438 branch-1.3 passed
+1 compile 37 branch-1.3 passed with JDK v1.8.0_222
+1 compile 39 branch-1.3 passed with JDK v1.7.0_232
+1 checkstyle 94 branch-1.3 passed
+1 shadedjars 151 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 branch-1.3 passed with JDK v1.8.0_222
+1 javadoc 39 branch-1.3 passed with JDK v1.7.0_232
0 spotbugs 161 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 158 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 98 the patch passed
+1 compile 36 the patch passed with JDK v1.8.0_222
+1 javac 36 the patch passed
+1 compile 37 the patch passed with JDK v1.7.0_232
+1 javac 37 the patch passed
+1 checkstyle 86 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 144 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 534 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 32 the patch passed with JDK v1.8.0_222
+1 javadoc 38 the patch passed with JDK v1.7.0_232
+1 findbugs 156 the patch passed
_ Other Tests _
+1 unit 5580 hbase-server in the patch passed.
+1 asflicense 29 The patch does not generate ASF License warnings.
7920
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ea2a6c88e389 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / d2b310b
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/testReport/
Max. process+thread count 4223 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/5/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 159 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 485 branch-1.3 passed
+1 compile 55 branch-1.3 passed
+1 checkstyle 126 branch-1.3 passed
-1 shadedjars 15 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 57 branch-1.3 passed
0 spotbugs 183 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 179 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 151 the patch passed
+1 compile 54 the patch passed
+1 javac 54 the patch passed
+1 checkstyle 122 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 12 patch has 10 errors when building our shaded downstream artifacts.
+1 hadoopcheck 676 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 39 the patch passed
+1 findbugs 176 the patch passed
_ Other Tests _
-1 unit 9407 hbase-server in the patch failed.
+1 asflicense 22 The patch does not generate ASF License warnings.
11838
Reason Tests
Failed junit tests hadoop.hbase.snapshot.TestFlushSnapshotFromClient
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c2b8c7ef6615 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / b97621b
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/branch-shadedjars.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/testReport/
Max. process+thread count 4499 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/7/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 3163 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 465 branch-1.3 passed
+1 compile 52 branch-1.3 passed with JDK v1.8.0_222
+1 compile 52 branch-1.3 passed with JDK v1.7.0_232
+1 checkstyle 127 branch-1.3 passed
+1 shadedjars 206 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 41 branch-1.3 passed with JDK v1.8.0_222
+1 javadoc 49 branch-1.3 passed with JDK v1.7.0_232
0 spotbugs 213 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 209 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 131 the patch passed
+1 compile 46 the patch passed with JDK v1.8.0_222
+1 javac 46 the patch passed
+1 compile 50 the patch passed with JDK v1.7.0_232
+1 javac 50 the patch passed
+1 checkstyle 119 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 199 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 666 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 33 the patch passed with JDK v1.8.0_222
+1 javadoc 50 the patch passed with JDK v1.7.0_232
+1 findbugs 212 the patch passed
_ Other Tests _
-1 unit 14119 hbase-server in the patch failed.
+1 asflicense 168 The patch does not generate ASF License warnings.
20347
Reason Tests
Failed junit tests hadoop.hbase.master.handler.TestEnableTableHandler
hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
hadoop.hbase.regionserver.TestRegionReplicaFailover
hadoop.hbase.snapshot.TestFlushSnapshotFromClient
hadoop.hbase.client.TestAdmin2
hadoop.hbase.regionserver.TestEncryptionKeyRotation
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ddcf2e148861 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / b97621b
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/testReport/
Max. process+thread count 3815 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/6/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 111 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 528 branch-1.3 passed
+1 compile 95 branch-1.3 passed
+1 checkstyle 186 branch-1.3 passed
-1 shadedjars 50 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 58 branch-1.3 passed
0 spotbugs 155 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 153 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 102 the patch passed
+1 compile 47 the patch passed
+1 javac 47 the patch passed
+1 checkstyle 115 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 10 patch has 10 errors when building our shaded downstream artifacts.
+1 hadoopcheck 692 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 78 the patch passed
+1 findbugs 303 the patch passed
_ Other Tests _
-1 unit 3425 hbase-server in the patch failed.
+1 asflicense 14 The patch does not generate ASF License warnings.
6090
Reason Tests
Failed junit tests hadoop.hbase.ipc.TestSimpleRpcScheduler
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3f84772d5107 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / f8695bb
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/branch-shadedjars.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/testReport/
Max. process+thread count 708 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/8/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd
Copy link
Contributor

Reidddddd commented Aug 16, 2019 •
edited
Loading

Backport HBASE-19863?

First skimmed(not in detailed), looks like they are quite different?

@eomiks
Copy link
Contributor Author

eomiks commented Aug 16, 2019 •
edited
Loading

@Reidddddd
at first, I thought backporting HBASE-19863 would make all the problem go away so I wrote that description. But through some tests and new patches, I realized there's more (bugs & patches for 1.4) there.

So, yeah. My first description was not updated property.
this is not simple backport of HBASE-19863. It's the backport of HBASE-19863 and a part of HBASE-17958 related to storeScanner SEEK/SKIP

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1720 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 483 branch-1.3 passed
+1 compile 47 branch-1.3 passed with JDK v1.8.0_222
+1 compile 49 branch-1.3 passed with JDK v1.7.0_232
+1 checkstyle 112 branch-1.3 passed
+1 shadedjars 201 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 41 branch-1.3 passed with JDK v1.8.0_222
+1 javadoc 49 branch-1.3 passed with JDK v1.7.0_232
0 spotbugs 209 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 205 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 135 the patch passed
+1 compile 46 the patch passed with JDK v1.8.0_222
+1 javac 46 the patch passed
+1 compile 53 the patch passed with JDK v1.7.0_232
+1 javac 53 the patch passed
+1 checkstyle 114 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 215 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 672 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 33 the patch passed with JDK v1.8.0_222
+1 javadoc 47 the patch passed with JDK v1.7.0_232
+1 findbugs 210 the patch passed
_ Other Tests _
-1 unit 8895 hbase-server in the patch failed.
+1 asflicense 57 The patch does not generate ASF License warnings.
13483
Reason Tests
Failed junit tests hadoop.hbase.master.cleaner.TestSnapshotFromMaster
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2ca049f4c67a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / 3351124
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/testReport/
Max. process+thread count 3943 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/9/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 2213 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 476 branch-1.3 passed
+1 compile 53 branch-1.3 passed
+1 checkstyle 128 branch-1.3 passed
-1 shadedjars 16 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 44 branch-1.3 passed
0 spotbugs 170 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 167 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 139 the patch passed
+1 compile 54 the patch passed
+1 javac 54 the patch passed
+1 checkstyle 122 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 13 patch has 10 errors when building our shaded downstream artifacts.
+1 hadoopcheck 712 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 39 the patch passed
+1 findbugs 174 the patch passed
_ Other Tests _
-1 unit 7889 hbase-server in the patch failed.
+1 asflicense 23 The patch does not generate ASF License warnings.
12369
Reason Tests
Failed junit tests hadoop.hbase.TestPartialResultsFromClientSide
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux bfee842652dd 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / 2bb4a91
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/branch-shadedjars.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/testReport/
Max. process+thread count 4623 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/10/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 109 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 460 branch-1.3 passed
+1 compile 39 branch-1.3 passed
+1 checkstyle 110 branch-1.3 passed
-1 shadedjars 11 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 37 branch-1.3 passed
0 spotbugs 140 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 138 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 119 the patch passed
+1 compile 39 the patch passed
+1 javac 39 the patch passed
+1 checkstyle 105 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 10 patch has 10 errors when building our shaded downstream artifacts.
+1 hadoopcheck 592 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 30 the patch passed
+1 findbugs 144 the patch passed
_ Other Tests _
-1 unit 7415 hbase-server in the patch failed.
+1 asflicense 26 The patch does not generate ASF License warnings.
9478
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestCompactSplitThread
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 220bf1eff47d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484@2/out/precommit/personality/provided.sh
git revision branch-1.3 / 102fbb5
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/branch-shadedjars.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/testReport/
Max. process+thread count 4496 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/11/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 78 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
-1 mvninstall 391 root in branch-1.3 failed.
-1 compile 41 hbase-server in branch-1.3 failed.
+1 checkstyle 108 branch-1.3 passed
-1 shadedjars 12 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 39 branch-1.3 passed
0 spotbugs 90 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 38 hbase-server in branch-1.3 failed.
_ Patch Compile Tests _
-1 mvninstall 71 root in the patch failed.
-1 compile 40 hbase-server in the patch failed.
-1 javac 40 hbase-server in the patch failed.
+1 checkstyle 105 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 10 patch has 10 errors when building our shaded downstream artifacts.
-1 hadoopcheck 98 The patch causes 18 errors with Hadoop v2.4.1.
-1 hadoopcheck 203 The patch causes 18 errors with Hadoop v2.5.2.
-1 hadoopcheck 314 The patch causes 18 errors with Hadoop v2.6.5.
-1 hadoopcheck 419 The patch causes 18 errors with Hadoop v2.7.7.
+1 javadoc 30 the patch passed
-1 findbugs 38 hbase-server in the patch failed.
_ Other Tests _
-1 unit 39 hbase-server in the patch failed.
+1 asflicense 13 The patch does not generate ASF License warnings.
1546
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3f5ab43128fa 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / ca0390c
Default Java 1.8.0_222
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-compile-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-shadedjars.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-compile-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.4.1.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.5.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.6.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-javac-2.7.7.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/testReport/
Max. process+thread count 77 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/12/console
versions git=1.9.1 maven=3.0.5
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@eomiks
HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…
a944395 
…ilter could throw AssertionError (backport of HBASE-19863)

+ add a line at the end of file
@Reidddddd
Copy link
Contributor

LGTM.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1968 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 454 branch-1.3 passed
+1 compile 41 branch-1.3 passed with JDK v1.8.0_222
+1 compile 41 branch-1.3 passed with JDK v1.7.0_232
+1 checkstyle 99 branch-1.3 passed
+1 shadedjars 160 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 40 branch-1.3 passed with JDK v1.8.0_222
+1 javadoc 43 branch-1.3 passed with JDK v1.7.0_232
0 spotbugs 181 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 177 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 112 the patch passed
+1 compile 41 the patch passed with JDK v1.8.0_222
+1 javac 41 the patch passed
+1 compile 41 the patch passed with JDK v1.7.0_232
+1 javac 41 the patch passed
+1 checkstyle 90 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 197 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 764 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 40 the patch passed with JDK v1.8.0_222
+1 javadoc 42 the patch passed with JDK v1.7.0_232
+1 findbugs 186 the patch passed
_ Other Tests _
-1 unit 10107 hbase-server in the patch failed.
+1 asflicense 24 The patch does not generate ASF License warnings.
14772
Reason Tests
Failed junit tests hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
hadoop.hbase.regionserver.TestEncryptionKeyRotation
hadoop.hbase.regionserver.TestSplitTransactionOnCluster
hadoop.hbase.master.TestAssignmentManagerOnCluster
hadoop.hbase.client.TestFromClientSideWithCoprocessor
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e4a90bd4c2a3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / 40cf771
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/testReport/
Max. process+thread count 3932 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/14/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 1234 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 456 branch-1.3 passed
+1 compile 36 branch-1.3 passed with JDK v1.8.0_222
+1 compile 40 branch-1.3 passed with JDK v1.7.0_232
+1 checkstyle 91 branch-1.3 passed
+1 shadedjars 153 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 branch-1.3 passed with JDK v1.8.0_222
+1 javadoc 39 branch-1.3 passed with JDK v1.7.0_232
0 spotbugs 167 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 164 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 122 the patch passed
+1 compile 35 the patch passed with JDK v1.8.0_222
+1 javac 35 the patch passed
+1 compile 42 the patch passed with JDK v1.7.0_232
+1 javac 42 the patch passed
+1 checkstyle 90 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 146 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 636 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 26 the patch passed with JDK v1.8.0_222
+1 javadoc 38 the patch passed with JDK v1.7.0_232
+1 findbugs 162 the patch passed
_ Other Tests _
+1 unit 7054 hbase-server in the patch passed.
+1 asflicense 23 The patch does not generate ASF License warnings.
10718
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/16/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d5e71ad519e1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / cd7bf70
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/16/testReport/
Max. process+thread count 3807 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/16/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 48 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-1.3 Compile Tests _
+1 mvninstall 450 branch-1.3 passed
+1 compile 43 branch-1.3 passed
+1 checkstyle 110 branch-1.3 passed
-1 shadedjars 12 branch has 10 errors when building our shaded downstream artifacts.
+1 javadoc 40 branch-1.3 passed
0 spotbugs 148 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 146 branch-1.3 passed
_ Patch Compile Tests _
+1 mvninstall 113 the patch passed
+1 compile 41 the patch passed
+1 javac 41 the patch passed
+1 checkstyle 104 hbase-server: The patch generated 0 new + 372 unchanged - 23 fixed = 372 total (was 395)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 10 patch has 10 errors when building our shaded downstream artifacts.
+1 hadoopcheck 586 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 31 the patch passed
+1 findbugs 143 the patch passed
_ Other Tests _
-1 unit 6651 hbase-server in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
8644
Reason Tests
Failed junit tests hadoop.hbase.trace.TestHTraceHooks
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/Dockerfile
GITHUB PR #484
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2b6815fa53f6 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
git revision branch-1.3 / 6a0c26f
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/branch-shadedjars.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/testReport/
Max. process+thread count 4246 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd Reidddddd merged commit 957d968 into apache:branch-1.3 Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reidddddd Reidddddd Reidddddd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eomiks @Apache-HBase @Reidddddd