Skip to content

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022
Merged

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8604cd
HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…
2005hithlj Aug 4, 2022
5a468c5
HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…
2005hithlj Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,24 @@ public boolean evaluate() throws Exception {
* @param greaterThan size of replicationLoadSourceList must be greater before we proceed
*/
private List<ReplicationLoadSource> waitOnMetricsReport(int greaterThan, ServerName serverName)
throws IOException {
ClusterMetrics metrics = hbaseAdmin.getClusterMetrics(EnumSet.of(Option.LIVE_SERVERS));
List<ReplicationLoadSource> list =
metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList();
while (list.size() <= greaterThan) {
Threads.sleep(1000);
}
return list;
throws Exception {
UTIL1.waitFor(30000, 1000, new Waiter.ExplainingPredicate<Exception>() {
@Override
public boolean evaluate() throws Exception {
List<ReplicationLoadSource> list =
hbaseAdmin.getClusterMetrics(EnumSet.of(Option.LIVE_SERVERS)).getLiveServerMetrics()
.get(serverName).getReplicationLoadSourceList();
return list.size() > greaterThan;
}

@Override
public String explainFailure() throws Exception {
return "The ReplicationLoadSourceList's size is lesser than or equal to " + greaterThan
+ " for " + serverName;
}
});

return hbaseAdmin.getClusterMetrics(EnumSet.of(Option.LIVE_SERVERS)).getLiveServerMetrics()
.get(serverName).getReplicationLoadSourceList();
}
}