HBASE-27199 Clean up error-prone findings in hbase-asyncfs #4620

apurtell · 2022-07-13T23:33:33Z

No description provided.

Apache-HBase · 2022-07-13T23:52:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	3m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	3m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 2s	hbase-asyncfs in the patch passed.
		16m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4620
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7d2f74d3b9a5 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `01b45e2`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/testReport/
Max. process+thread count	485 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-13T23:54:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 29s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	shadedjars	4m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	4m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 5s	hbase-asyncfs in the patch passed.
		18m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4620
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cd6b356b540d 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `01b45e2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/testReport/
Max. process+thread count	522 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-14T00:03:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 26s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	checkstyle	0m 10s	master passed
+1 💚	spotless	0m 53s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	hbase-asyncfs generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
-0 ⚠️	checkstyle	0m 8s	hbase-asyncfs: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 58s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotless	0m 19s	patch has 21 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		28m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4620
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 3c3a00d33509 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `01b45e2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-asyncfs.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-14T02:40:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	4m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	4m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 11s	hbase-asyncfs in the patch passed.
		20m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4620
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1201266922db 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `01b45e2`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/testReport/
Max. process+thread count	525 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-14T02:41:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 11s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 13s	hbase-asyncfs in the patch passed.
		21m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4620
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ae53089805ea 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `01b45e2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/testReport/
Max. process+thread count	502 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-14T02:49:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 7s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	checkstyle	0m 8s	master passed
+1 💚	spotless	0m 53s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	hbase-asyncfs generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
+1 💚	checkstyle	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 19s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 24s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		28m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4620
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f8aa56a55cc7 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `01b45e2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-asyncfs U: hbase-asyncfs
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4620/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

I think we could implement something like a FutureUtils.addListener and add a SuppressWarnings on that method.

And also, usually we do not care about the returned ChannelFuture when calling channel.write, we could also implement something like a logging listener to eat the future(and suppress the warning by using the above addListener method).

Apache9 · 2022-07-15T02:13:02Z

...src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java

-            sendSaslMessage(ctx, response, cipherOptions);
+            ChannelFuture sendFuture = sendSaslMessage(ctx, response, cipherOptions);
            ctx.flush();
+            sendFuture.get();


This is a no no, we should not do any blocking operations in netty handler...

Apache9 · 2022-07-16T02:58:18Z

PTAL at #4628 ? Where I use spotless replaceRegex to cleanup the MissingSumamry warnings where we have only one @return javadoc tag.

So the patch here could focus on other more important changes.

Apache9 · 2022-07-16T03:49:02Z

Apache9@3cd7eef

And this is what I proposed on how to fix the FutureReturnValueIgnored. PTAL to see if it is suitable.

Thanks.

HBASE-27199 Clean up error-prone findings in hbase-asyncfs

9937039

spotless:apply

7416a27

Apache9 reviewed Jul 15, 2022

View reviewed changes

apurtell closed this Jul 18, 2022

apurtell deleted the HBASE-27199 branch July 18, 2022 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-27199 Clean up error-prone findings in hbase-asyncfs #4620

HBASE-27199 Clean up error-prone findings in hbase-asyncfs #4620

Uh oh!

apurtell commented Jul 13, 2022

Uh oh!

Apache-HBase commented Jul 13, 2022

Uh oh!

Apache-HBase commented Jul 13, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache9 left a comment

Uh oh!

Apache9 Jul 15, 2022

Uh oh!

Apache9 commented Jul 16, 2022

Uh oh!

Apache9 commented Jul 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-27199 Clean up error-prone findings in hbase-asyncfs #4620

HBASE-27199 Clean up error-prone findings in hbase-asyncfs #4620

Uh oh!

Conversation

apurtell commented Jul 13, 2022

Uh oh!

Apache-HBase commented Jul 13, 2022

Uh oh!

Apache-HBase commented Jul 13, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache-HBase commented Jul 14, 2022

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 Jul 15, 2022

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Jul 16, 2022

Uh oh!

Apache9 commented Jul 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants