Skip to content

HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2022
Merged

HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone #4617

merged 3 commits into from
Aug 12, 2022

Conversation

@apurtell
Copy link
Contributor

@apurtell apurtell commented Jul 12, 2022 •
edited
Loading

  • Reorganize MOB compaction tests for more reuse.
  • Add tests for mob compaction after snapshot clone operations
  • note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez [email protected]

Ported to branch-2 for HBASE-27154

Co-authored-by: Andrew Purtell [email protected]

@apurtell apurtell requested a review from wchevreuil July 12, 2022 23:56
@apurtell
Copy link
Contributor Author

All MOB unit tests pass for me locally:

[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.mob.TestMobStoreCompaction
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileName
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.443 s - in org.apache.hadoop.hbase.mob.TestMobFileName
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionRegularRegionBatchMode
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.708 s - in org.apache.hadoop.hbase.mob.TestMobStoreCompaction
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionOptMode
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 167.5 s - in org.apache.hadoop.hbase.mob.TestMobCompactionOptMode
[INFO] Running org.apache.hadoop.hbase.mob.TestMobDataBlockEncoding
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.027 s - in org.apache.hadoop.hbase.mob.TestMobDataBlockEncoding
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionWithDefaults
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 269.02 s - in org.apache.hadoop.hbase.mob.TestMobCompactionRegularRegionBatchMode
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionOptRegionBatchMode
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 162.783 s - in org.apache.hadoop.hbase.mob.TestMobCompactionWithDefaults
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFile
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.944 s - in org.apache.hadoop.hbase.mob.TestMobFile
[INFO] Running org.apache.hadoop.hbase.mob.TestMobStoreScanner
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.321 s - in org.apache.hadoop.hbase.mob.TestMobStoreScanner
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileCleanerChore
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.639 s - in org.apache.hadoop.hbase.mob.TestMobFileCleanerChore
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileLink
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.564 s - in org.apache.hadoop.hbase.mob.TestMobFileLink
[INFO] Running org.apache.hadoop.hbase.mob.TestMobWithByteBuffAllocator
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.788 s - in org.apache.hadoop.hbase.mob.TestMobWithByteBuffAllocator
[INFO] Running org.apache.hadoop.hbase.mob.TestMobFileCache
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.168 s - in org.apache.hadoop.hbase.mob.TestMobFileCache
[INFO] Running org.apache.hadoop.hbase.mob.TestMobCompactionRegularMode
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 48.695 s - in org.apache.hadoop.hbase.mob.TestMobCompactionRegularMode
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.397 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterSplittingRegions
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 269.391 s - in org.apache.hadoop.hbase.mob.TestMobCompactionOptRegionBatchMode
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSimple
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.287 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.717 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientClone
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientError
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.984 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSimple
[INFO] Running org.apache.hadoop.hbase.client.TestMobSnapshotFromClient
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.227 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientError
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientGetCompactionState
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.527 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientGetCompactionState
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.1 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion
[INFO] Running org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientCloneLinksAfterDelete
[INFO] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 70.423 s - in org.apache.hadoop.hbase.client.TestMobSnapshotFromClient
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.803 s - in org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClientCloneLinksAfterDelete
[INFO] Running org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterTruncate
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.497 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientSchemaChange
[INFO] Running org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.713 s - in org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClientAfterTruncate
[INFO] Running org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.296 s - in org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient
[INFO] Running org.apache.hadoop.hbase.snapshot.TestMobRestoreSnapshotHelper
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 92.566 s - in org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence
[INFO] Running org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.037 s - in org.apache.hadoop.hbase.snapshot.TestMobRestoreSnapshotHelper
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.427 s - in org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
[INFO] Results:
[INFO] Tests run: 92, Failures: 0, Errors: 0, Skipped: 0

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 2m 24s branch-2 passed
+1 💚 compile 2m 40s branch-2 passed
+1 💚 checkstyle 0m 40s branch-2 passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 5s the patch passed
-1 ❌ compile 0m 56s hbase-server in the patch failed.
-0 ⚠️ javac 0m 28s hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)
-0 ⚠️ javac 0m 56s hbase-server in the patch failed.
-0 ⚠️ checkstyle 0m 27s hbase-server: The patch generated 2 new + 34 unchanged - 0 fixed = 36 total (was 34)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 46s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
-1 ❌ spotless 0m 33s patch has 33 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 1m 50s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
29m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4617
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux f07e066ee4df 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbfe7b3
Default Java AdoptOpenJDK-1.8.0_282-b08
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 64 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 14s branch-2 passed
+1 💚 compile 0m 54s branch-2 passed
+1 💚 shadedjars 3m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 shadedjars 3m 39s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s the patch passed
_ Other Tests _
+1 💚 unit 1m 28s hbase-common in the patch passed.
-1 ❌ unit 195m 32s hbase-server in the patch failed.
214m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux c0b2af789d4e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbfe7b3
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/testReport/
Max. process+thread count 2430 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 47s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 35s branch-2 passed
+1 💚 compile 1m 19s branch-2 passed
+1 💚 shadedjars 4m 39s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 52s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 1m 13s the patch passed
+1 💚 javac 1m 13s the patch passed
+1 💚 shadedjars 4m 33s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 29s hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
_ Other Tests _
+1 💚 unit 2m 9s hbase-common in the patch passed.
+1 💚 unit 228m 18s hbase-server in the patch passed.
254m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8bca2e086ac7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / fbfe7b3
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/testReport/
Max. process+thread count 2290 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@BukrosSzabolcs
Copy link
Contributor

I got the same results:
[INFO] Results: [INFO] [INFO] Tests run: 92, Failures: 0, Errors: 0, Skipped: 0

@apurtell
Copy link
Contributor Author

Ah, I changed HBaseTestingUtility and then did not run spotless after. Pushed updates to fix that.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 23s branch-2 passed
+1 💚 compile 2m 42s branch-2 passed
+1 💚 checkstyle 0m 40s branch-2 passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 45s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for patch
+1 💚 mvninstall 2m 5s the patch passed
-1 ❌ compile 0m 57s hbase-server in the patch failed.
-0 ⚠️ javac 0m 27s hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)
-0 ⚠️ javac 0m 57s hbase-server in the patch failed.
+1 💚 checkstyle 0m 38s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 50s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 48s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
29m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4617
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux ddc8db072026 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 47230c4
Default Java AdoptOpenJDK-1.8.0_282-b08
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
Max. process+thread count 65 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell force-pushed the HBASE-27154-23723-2 branch from 5b3f765 to 45713c1 Compare July 13, 2022 19:18
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 16s branch-2 passed
+1 💚 compile 0m 55s branch-2 passed
+1 💚 shadedjars 3m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 9s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 shadedjars 3m 38s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s the patch passed
_ Other Tests _
+1 💚 unit 1m 27s hbase-common in the patch passed.
-1 ❌ unit 187m 33s hbase-server in the patch failed.
206m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux 233ee5966bd2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 47230c4
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/testReport/
Max. process+thread count 2406 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 55s branch-2 passed
+1 💚 compile 0m 59s branch-2 passed
+1 💚 shadedjars 4m 19s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 2m 39s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 shadedjars 4m 17s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 24s hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
_ Other Tests _
+1 💚 unit 1m 39s hbase-common in the patch passed.
+1 💚 unit 185m 4s hbase-server in the patch passed.
207m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux e74505c105ce 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 47230c4
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/testReport/
Max. process+thread count 2495 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 14s branch-2 passed
+1 💚 compile 2m 42s branch-2 passed
+1 💚 checkstyle 0m 39s branch-2 passed
+1 💚 spotless 0m 40s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 34s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 1s the patch passed
-1 ❌ compile 2m 9s hbase-server in the patch failed.
-0 ⚠️ javac 0m 28s hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)
-0 ⚠️ javac 2m 9s hbase-server in the patch failed.
+1 💚 checkstyle 0m 37s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 38s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 48s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
30m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4617
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux ecd6516e872f 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 70a561e
Default Java AdoptOpenJDK-1.8.0_282-b08
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
Max. process+thread count 65 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

Precommit test failures are similar to recent flakes on other issues, and are not related to this change.

@apurtell
Copy link
Contributor Author

A similar error-prone finding as before, but in a different file.

@apurtell apurtell force-pushed the HBASE-27154-23723-2 branch from 45713c1 to ebf4a17 Compare July 13, 2022 20:19
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 8m 30s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 5s branch-2 passed
+1 💚 compile 0m 55s branch-2 passed
+1 💚 shadedjars 3m 39s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 9s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 shadedjars 3m 39s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s the patch passed
_ Other Tests _
+1 💚 unit 1m 25s hbase-common in the patch passed.
+1 💚 unit 186m 25s hbase-server in the patch passed.
213m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux d063f8d31a72 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 70a561e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/testReport/
Max. process+thread count 2391 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 2m 46s branch-2 passed
+1 💚 compile 1m 5s branch-2 passed
+1 💚 shadedjars 3m 54s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 46s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 34s the patch passed
+1 💚 compile 1m 5s the patch passed
+1 💚 javac 1m 5s the patch passed
+1 💚 shadedjars 3m 56s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 27s hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
_ Other Tests _
+1 💚 unit 1m 51s hbase-common in the patch passed.
+1 💚 unit 197m 16s hbase-server in the patch passed.
219m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux 603595529e67 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 70a561e
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/testReport/
Max. process+thread count 2426 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 16s branch-2 passed
+1 💚 compile 2m 44s branch-2 passed
+1 💚 checkstyle 0m 46s branch-2 passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 47s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 compile 2m 44s the patch passed
-0 ⚠️ javac 0m 31s hbase-common generated 2 new + 153 unchanged - 2 fixed = 155 total (was 155)
+1 💚 checkstyle 0m 46s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 38s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 58s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
31m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4617
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux dbc8e549c887 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 70a561e
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
Max. process+thread count 64 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 9s branch-2 passed
+1 💚 compile 0m 55s branch-2 passed
+1 💚 shadedjars 3m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 8s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 shadedjars 3m 41s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s the patch passed
_ Other Tests _
+1 💚 unit 1m 28s hbase-common in the patch passed.
+1 💚 unit 190m 24s hbase-server in the patch passed.
209m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux 30b51a7070e1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 70a561e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/testReport/
Max. process+thread count 2414 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 34s branch-2 passed
+1 💚 compile 1m 5s branch-2 passed
+1 💚 shadedjars 3m 53s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 44s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 38s the patch passed
+1 💚 compile 1m 5s the patch passed
+1 💚 javac 1m 5s the patch passed
+1 💚 shadedjars 3m 57s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 27s hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
_ Other Tests _
+1 💚 unit 1m 51s hbase-common in the patch passed.
+1 💚 unit 202m 50s hbase-server in the patch passed.
225m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1b2bde033584 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 70a561e
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/testReport/
Max. process+thread count 2312 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

busbey and others added 3 commits July 19, 2022 10:23
@busbey @apurtell
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
7053461 
…hot clone (apache#1446)

* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez <[email protected]>
@apurtell
spotless:apply to fix HBaseTestingUtility
51eeb5d
@apurtell
Fix error-prone errors
6c4035d
@apurtell apurtell force-pushed the HBASE-27154-23723-2 branch from ebf4a17 to 6c4035d Compare July 19, 2022 17:27
@apurtell
Copy link
Contributor Author

Working on old information, a github page rendering that was not updating properly, I thought the build was still failing in compilation due to error-prone and changed how the IOExceptions are formatted again, this time with string concatenation instead of String#format. I assume this is not a problem @wchevreuil and will go ahead and merge this if I don't hear back in 24 hours or so.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 14s branch-2 passed
+1 💚 compile 2m 45s branch-2 passed
+1 💚 checkstyle 0m 46s branch-2 passed
+1 💚 spotless 0m 46s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 46s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 10s the patch passed
+1 💚 compile 2m 44s the patch passed
-0 ⚠️ javac 0m 31s hbase-common generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154)
-0 ⚠️ javac 2m 13s hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚 checkstyle 0m 46s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 58s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 57s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
32m 9s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4617
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 90025c45c9c7 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5cf9a9b
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count 60 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 1s branch-2 passed
+1 💚 compile 0m 58s branch-2 passed
+1 💚 shadedjars 4m 19s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 39s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 2m 37s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 shadedjars 4m 18s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 24s hbase-server generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
_ Other Tests _
+1 💚 unit 1m 40s hbase-common in the patch passed.
+1 💚 unit 191m 40s hbase-server in the patch passed.
215m 48s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8999940d244f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5cf9a9b
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/testReport/
Max. process+thread count 2494 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 2m 17s branch-2 passed
+1 💚 compile 0m 55s branch-2 passed
+1 💚 shadedjars 3m 42s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 10s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
+1 💚 shadedjars 3m 42s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 39s the patch passed
_ Other Tests _
+1 💚 unit 1m 31s hbase-common in the patch passed.
+1 💚 unit 208m 23s hbase-server in the patch passed.
228m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4617
Optional Tests javac javadoc unit shadedjars compile
uname Linux f561acb23217 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5cf9a9b
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/testReport/
Max. process+thread count 2335 (vs. ulimit of 12500)
modules C: hbase-common hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4617/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@huaxiangsun
Copy link
Contributor

Seems everything is good, merge it to branch-2 and do a backport to branch-2.5.

@huaxiangsun huaxiangsun merged commit f36b349 into apache:branch-2 Aug 12, 2022
huaxiangsun pushed a commit to huaxiangsun/hbase that referenced this pull request Aug 12, 2022
@apurtell @busbey
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
997e4da 
…hot clone (apache#4617)

* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (apache#1446)

* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez <[email protected]>

* spotless:apply to fix HBaseTestingUtility

* Fix error-prone errors

Signed-off-by: Esteban Gutierrez <[email protected]>
Co-authored-by: Sean Busbey <[email protected]>
@huaxiangsun huaxiangsun mentioned this pull request Aug 12, 2022
Merged
huaxiangsun added a commit that referenced this pull request Aug 15, 2022
@huaxiangsun @apurtell @busbey
HBASE-23723 Ensure MOB compaction works in optimized mode after snaps…
e595f15 
…hot clone (#4617) (#4704)

* HBASE-23723 Ensure MOB compaction works in optimized mode after snapshot clone (#1446)

* Reorganize MOB compaction tests for more reuse.
* Add tests for mob compaction after snapshot clone operations
* note the original table used to write a given mob hfile and use that to find it later.

Signed-off-by: Esteban Gutierrez <[email protected]>

* spotless:apply to fix HBaseTestingUtility

* Fix error-prone errors

Signed-off-by: Esteban Gutierrez <[email protected]>
Co-authored-by: Sean Busbey <[email protected]>

Signed-off-by: Esteban Gutierrez <[email protected]>
Co-authored-by: Andrew Purtell <[email protected]>
Co-authored-by: Sean Busbey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@apurtell @Apache-HBase @BukrosSzabolcs @huaxiangsun @wchevreuil @busbey