Skip to content

HBASE-27193 TestZooKeeper is flaky #4615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2022
Merged

HBASE-27193 TestZooKeeper is flaky #4615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,15 @@ public void testRegionAssignmentAfterMasterRecoveryDueToZKExpiry() throws Except
m.getZooKeeper().close();
MockLoadBalancer.retainAssignCalled = false;
final int expectedNumOfListeners = countPermanentListeners(zkw);
// the master could already been aborted by some background tasks but here we call abort
// directly to make sure this will happen
m.abort("Test recovery from zk session expired",
new KeeperException.SessionExpiredException());
assertTrue(m.isStopped()); // Master doesn't recover any more
// it is possible that our abort call above returned earlier because of someone else has
// already called abort, but it is possible that it has not finished the abort call yet so the
// isStopped flag is still false, let's wait for sometime.
TEST_UTIL.waitFor(5000, () -> m.isStopped()); // Master doesn't recover any more

// The recovered master should not call retainAssignment, as it is not a
// clean startup.
assertFalse("Retain assignment should not be called", MockLoadBalancer.retainAssignCalled);
Expand Down