Skip to content

Backport "HBASE-27153 Improvements to read-path tracing" to branch-2.5 #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

Backport "HBASE-27153 Improvements to read-path tracing" to branch-2.5 #4574

merged 1 commit into from
Aug 2, 2022

Conversation

@ndimiduk
Copy link
Member

This is a backport of #4572 .

@ndimiduk ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jun 23, 2022
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
apurtell
apurtell approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@apurtell apurtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying my approval over from #4572 but see my comment there.

@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk ndimiduk force-pushed the 27153-trace-read-path-branch-2.5 branch from e35cdc9 to 23a3878 Compare June 28, 2022 12:20
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@ndimiduk ndimiduk force-pushed the 27153-trace-read-path-branch-2.5 branch from 23a3878 to 9258380 Compare July 7, 2022 14:42
@ndimiduk ndimiduk mentioned this pull request Jul 7, 2022
Closed
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@apurtell
Copy link
Contributor

apurtell commented Jul 7, 2022

There are some flaky replication tests in the precommit results that are not related here.

@ndimiduk ndimiduk force-pushed the 27153-trace-read-path-branch-2.5 branch from 9258380 to f2b5f32 Compare August 1, 2022 12:04
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 15s branch-2.5 passed
+1 💚 compile 3m 28s branch-2.5 passed
+1 💚 checkstyle 1m 3s branch-2.5 passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
+1 💚 spotbugs 2m 30s branch-2.5 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 2s the patch passed
+1 💚 compile 3m 29s the patch passed
+1 💚 javac 3m 29s the patch passed
+1 💚 checkstyle 1m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 12s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 2m 49s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
38m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4574
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 0bc6adb0577b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 7aa46f0
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 65 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for branch
+1 💚 mvninstall 2m 44s branch-2.5 passed
+1 💚 compile 1m 28s branch-2.5 passed
+1 💚 shadedjars 3m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 3s branch-2.5 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 2m 30s the patch passed
+1 💚 compile 1m 25s the patch passed
+1 💚 javac 1m 25s the patch passed
+1 💚 shadedjars 3m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 2s the patch passed
_ Other Tests _
+1 💚 unit 2m 1s hbase-common in the patch passed.
+1 💚 unit 2m 55s hbase-client in the patch passed.
+1 💚 unit 187m 4s hbase-server in the patch passed.
213m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4574
Optional Tests javac javadoc unit shadedjars compile
uname Linux 12c6142e3a78 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 7aa46f0
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/testReport/
Max. process+thread count 2368 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 33s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 2m 52s branch-2.5 passed
+1 💚 compile 1m 24s branch-2.5 passed
+1 💚 shadedjars 4m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 59s branch-2.5 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 27s the patch passed
+1 💚 compile 1m 22s the patch passed
+1 💚 javac 1m 22s the patch passed
+1 💚 shadedjars 3m 57s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 56s the patch passed
_ Other Tests _
+1 💚 unit 1m 29s hbase-common in the patch passed.
+1 💚 unit 2m 51s hbase-client in the patch passed.
+1 💚 unit 193m 23s hbase-server in the patch passed.
222m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4574
Optional Tests javac javadoc unit shadedjars compile
uname Linux a69130d95ace 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.5 / 7aa46f0
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/testReport/
Max. process+thread count 2120 (vs. ulimit of 12500)
modules C: hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4574/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 472e810 into apache:branch-2.5 Aug 2, 2022
@ndimiduk ndimiduk deleted the 27153-trace-read-path-branch-2.5 branch August 2, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtell apurtell apurtell approved these changes

Assignees

No one assigned

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk @Apache-HBase @apurtell