Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions dev-support/hbase-personality.sh
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,55 @@ function hbaseanti_patchfile
return 0
}

######################################

add_test_type spotless

## @description spotless file filter
## @audience private
## @stability evolving
## @param filename
function spotless_filefilter
{
# always add spotless check as it can format almost all types of files
add_test spotless
}
## @description run spotless:check to check format issues
## @audience private
## @stability evolving
## @param repostatus
function spotless_rebuild
{
local repostatus=$1
local logfile="${PATCH_DIR}/${repostatus}-spotless.txt"

if ! verify_needed_test spotless; then
return 0
fi

big_console_header "Checking spotless on ${repostatus}"

start_clock

local -a maven_args=('spotless:check')

# disabled because "maven_executor" needs to return both command and args
# shellcheck disable=2046
echo_and_redirect "${logfile}" $(maven_executor) "${maven_args[@]}"

count=$(${GREP} -c '\[ERROR\]' "${logfile}")
if [[ ${count} -gt 0 ]]; then
add_vote_table -1 spotless "${repostatus} has ${count} errors when running spotless:check, run spotless:apply to fix."
add_footer_table spotless "@@BASE@@/${repostatus}-spotless.txt"
return 1
fi

add_vote_table +1 spotless "${repostatus} has no errors when running spotless:check."
return 0
}

######################################

## @description process the javac output for generating WARNING/ERROR
## @audience private
## @stability evolving
Expand Down
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2756,6 +2756,10 @@
<include>**/*.txt</include>
<include>*.txt</include>
</includes>
<excludes>
<exclude>**/target/**</exclude>
<exclude>**/dependency-reduced-pom.xml</exclude>
</excludes>
<!-- define the steps to apply to those files -->
<trimTrailingWhitespace/>
<endWithNewline/>
Expand Down