HBASE-26994 MasterFileSystem create directory without permission check #4391

skysiders · 2022-05-01T07:36:22Z

HBASE-26994 MasterFileSystem create directory without permission check

Method checkStagingDir and checkSubDir first check if directory is exist ,if not , create it with special permission. If exist then setPermission for this directory. BUT if not exist ,we still need set special permission for this directory.

Apache-HBase · 2022-05-01T08:11:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	checkstyle	0m 38s	master passed
+1 💚	spotbugs	1m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	2m 13s	the patch passed
+1 💚	javac	2m 13s	the patch passed
-0 ⚠️	checkstyle	0m 35s	hbase-server: The patch generated 1 new + 7 unchanged - 1 fixed = 8 total (was 8)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 41s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		30m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4391
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 2817fe379dce 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `152ecad`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-01T10:51:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	0m 41s	master passed
+1 💚	shadedjars	3m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 22s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	174m 21s	hbase-server in the patch passed.
		190m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4391
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux adff5b7492c9 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `152ecad`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/testReport/
Max. process+thread count	3187 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-01T11:20:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	shadedjars	3m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	shadedjars	3m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	203m 23s	hbase-server in the patch passed.
		220m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4391
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0c83d0e472b6 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `152ecad`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/testReport/
Max. process+thread count	2551 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-01T15:48:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 15s	master passed
+1 💚	compile	2m 18s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	spotbugs	1m 17s	master passed
-0 ⚠️	patch	1m 23s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	checkstyle	0m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 25s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 3s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		33m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4391
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d4db98cd877b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9c8c9e7`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-01T19:42:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 39s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	4m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
-0 ⚠️	patch	5m 6s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 53s	the patch passed
+1 💚	javac	0m 53s	the patch passed
+1 💚	shadedjars	4m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	245m 2s	hbase-server in the patch passed.
		267m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4391
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 83356f01d7fc 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9c8c9e7`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/testReport/
Max. process+thread count	2465 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-01T19:53:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 4s	master passed
+1 💚	compile	0m 41s	master passed
+1 💚	shadedjars	4m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
-0 ⚠️	patch	4m 56s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 53s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	257m 37s	hbase-server in the patch failed.
		278m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4391
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ebc2d0d87391 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9c8c9e7`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/testReport/
Max. process+thread count	2601 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4391/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

skysiders · 2022-05-03T07:16:36Z

Hi @apurtell @carp84 ,can you please take a look?

skysiders · 2022-05-05T08:31:17Z

Hi @virajjasani , could you please take a look at this? Thanks

virajjasani

One part of the change looks good, the other one looks redundant, please help me understand if that is not the case.
Thanks @skysiders

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java

skysiders · 2022-05-06T07:38:18Z

Hi @virajjasani , thanks for your review.I have another PR HBASE-26895.Could you please have a look?

#4391) Signed-off-by: Viraj Jasani <[email protected]>

apache#4391) Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit bba83dc) Change-Id: I337afb05d4afe271718af63b3086d6b6df88006b

fix permission bugs

fe7bfff

Resolving conflicts

93ea963

virajjasani reviewed May 5, 2022

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java Show resolved Hide resolved

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java Show resolved Hide resolved

skysiders requested a review from virajjasani May 6, 2022 00:57

virajjasani approved these changes May 6, 2022

View reviewed changes

skysiders mentioned this pull request May 8, 2022

HBASE-26985 check permission for SecureBulkLoadManager #4379

Merged

virajjasani merged commit 5d6c0a9 into apache:master May 8, 2022

virajjasani pushed a commit that referenced this pull request May 8, 2022

HBASE-26994 MasterFileSystem create directory without permission check (

ad2180b

#4391) Signed-off-by: Viraj Jasani <[email protected]>

virajjasani pushed a commit that referenced this pull request May 8, 2022

HBASE-26994 MasterFileSystem create directory without permission check (

38cd57c

#4391) Signed-off-by: Viraj Jasani <[email protected]>

virajjasani pushed a commit that referenced this pull request May 8, 2022

HBASE-26994 MasterFileSystem create directory without permission check (

bba83dc

#4391) Signed-off-by: Viraj Jasani <[email protected]>

skysiders mentioned this pull request Jan 5, 2023

HIVE-26887 Make sure dirPath has the correct permissions apache/hive#3894

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

HBASE-26994 MasterFileSystem create directory without permission check #4391

HBASE-26994 MasterFileSystem create directory without permission check #4391

Uh oh!

skysiders commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

skysiders commented May 3, 2022

Uh oh!

skysiders commented May 5, 2022

Uh oh!

virajjasani left a comment

Uh oh!

Uh oh!

Uh oh!

skysiders commented May 6, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

HBASE-26994 MasterFileSystem create directory without permission check #4391

HBASE-26994 MasterFileSystem create directory without permission check #4391

Uh oh!

Conversation

skysiders commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

Apache-HBase commented May 1, 2022

Uh oh!

skysiders commented May 3, 2022

Uh oh!

skysiders commented May 5, 2022

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

skysiders commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

skysiders commented May 6, 2022 •

edited

Loading