Skip to content

Conversation

@apurtell
Copy link
Contributor

@apurtell apurtell commented Mar 7, 2022

No description provided.

@apurtell apurtell requested a review from Apache9 March 7, 2022 19:14
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 44s master passed
+1 💚 compile 6m 20s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 21s the patch passed
+1 💚 compile 6m 13s the patch passed
+1 💚 javac 6m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 11m 13s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
34m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4179/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4179
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux 5ba81b10f92e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bcd9a9a
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 88 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4179/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

apurtell commented Mar 7, 2022

hbase-rest unit tests (and others) pass for me locally. I also tested this change with hbase-thirdparty=4.1.0 installed from RC into local maven cache. There were no failures.

Waiting for precommit results.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 5s master passed
+1 💚 compile 2m 12s master passed
+1 💚 shadedjars 4m 30s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 22s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 2m 5s the patch passed
+1 💚 javac 2m 5s the patch passed
+1 💚 shadedjars 4m 38s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 2m 35s root generated 2 new + 179 unchanged - 2 fixed = 181 total (was 181)
_ Other Tests _
+1 💚 unit 418m 45s root in the patch passed.
450m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4179/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4179
Optional Tests javac javadoc unit shadedjars compile
uname Linux d435ae9ff797 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bcd9a9a
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4179/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4179/1/testReport/
Max. process+thread count 2517 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4179/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the thirdparty 4.1.0 out before merging.

@apurtell
Copy link
Contributor Author

apurtell commented Mar 8, 2022

I see this duplicates changes proposed on #4164 . Thats fine. I will close this.

@apurtell apurtell closed this Mar 8, 2022
@apurtell apurtell deleted the HBASE-26732 branch March 8, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants