Skip to content

HBASE-26797 HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2022
Merged

HBASE-26797 HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta #4161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
237d954
HBASE-26797 HBase 1.x clients will choke on rep_barrier rows when sca…
bbeaudreault Mar 3, 2022
870b815
Add comment
bbeaudreault Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,6 +1287,11 @@ private RegionLocations locateRegionInMeta(TableName tableName, byte[] row,
s.setReversed(true);
s.withStartRow(metaKey);

// Adding a filter on CATALOG_FAMILY is necessary for compatibility
// with hbase 2.x and beyond, which adds additional column families.
// See HBASE-26797
s.addFamily(HConstants.CATALOG_FAMILY);

if (this.useMetaReplicas) {
s.setConsistency(Consistency.TIMELINE);
}
Expand Down
4 changes: 4 additions & 0 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ private static Result getClosestRowOrBefore(final Table metaTable, final TableNa
throws IOException {
byte[] searchRow = HRegionInfo.createRegionName(userTableName, row, HConstants.NINES, false);
Scan scan = Scan.createGetClosestRowOrBeforeReverseScan(searchRow);
// Adding a filter on CATALOG_FAMILY is necessary for compatibility
// with hbase 2.x and beyond, which adds additional column families.
// See HBASE-26797
scan.addFamily(HConstants.CATALOG_FAMILY);
Copy link
Contributor Author

@bbeaudreault bbeaudreault Mar 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real error comes from ConnectionManager, but I tried to audit all reads against meta table and this was the only other one (that I could find) which did not have a family specified. I figured I should add it while I'm here even if we haven't hit an issue with this yet.

if (useMetaReplicas) {
scan.setConsistency(Consistency.TIMELINE);
}
Expand Down