Backport "HBASE-26614 Refactor code related to "dump"ing ZK nodes (#3969)" to branch-2.5

[ndimiduk]

The code starting at ZKUtil.dump(ZKWatcher) is a small mess – it has cyclic dependencies woven
through itself, ZKWatcher and RecoverableZooKeeper. It also initializes a static variable in
ZKUtil through the factory for RecoverableZooKeeper instances. Let's decouple and clean it
up.

Signed-off-by: Duo Zhang [email protected]
Signed-off-by: Josh Elser [email protected]

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s	branch-2.5 passed
+1 💚	compile	2m 12s	branch-2.5 passed
+1 💚	shadedjars	6m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 26s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	compile	2m 12s	the patch passed
+1 💚	javac	2m 12s	the patch passed
+1 💚	shadedjars	6m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-zookeeper in the patch passed.
-1 ❌	unit	8m 10s	hbase-server in the patch failed.
+1 💚	unit	8m 7s	hbase-shell in the patch passed.
+1 💚	unit	0m 59s	hbase-it in the patch passed.
		50m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4062
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fb7c49267f10 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / 0771c04
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/testReport/
Max. process+thread count	2519 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 31s	branch-2.5 passed
+1 💚	compile	2m 24s	branch-2.5 passed
+1 💚	shadedjars	7m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	7m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-zookeeper in the patch passed.
-1 ❌	unit	7m 49s	hbase-server in the patch failed.
+1 💚	unit	6m 57s	hbase-shell in the patch passed.
+1 💚	unit	0m 55s	hbase-it in the patch passed.
		51m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4062
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 800f4c5145e7 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / 0771c04
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/testReport/
Max. process+thread count	2591 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 54s	branch-2.5 passed
+1 💚	compile	5m 1s	branch-2.5 passed
+1 💚	checkstyle	1m 48s	branch-2.5 passed
+1 💚	spotbugs	3m 23s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	4m 51s	the patch passed
-0 ⚠️	javac	0m 29s	hbase-zookeeper generated 5 new + 105 unchanged - 6 fixed = 110 total (was 111)
+1 💚	checkstyle	1m 46s	the patch passed
+1 💚	rubocop	0m 8s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 35s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚	spotbugs	3m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 52s	The patch does not generate ASF License warnings.
		61m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4062
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
uname	Linux 9d232ea9fafa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / 0771c04
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
Max. process+thread count	97 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4062/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.