HBASE-25465 Use javac --release option for supporting cross version compilation in create-release #3974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ndimiduk
commented
Dec 23, 2021
ndimiduk
commented
- Update our jdk11 build profile in the pom so that it uses the additional flag on javac, requires maven 3.6+.
- update create-release Dockerfile to use jdk11-headless
ndimiduk
requested review from
Apache9,
apurtell,
busbey,
madrob and
saintstack
|
Perhaps the change to |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Yes, let's have separated issues for these two changes. The create-release script needs manual verification. |
|
💔 -1 overall
This message was automatically generated. |
ndimiduk
force-pushed
the
25465-compile-on-jdk11
branch
from
3166260 to
6e1aa66
Compare
…ompilation Update our jdk11 build profile in the pom so that it uses the additional flag on javac, requires maven 3.6+.
ndimiduk
force-pushed
the
25465-compile-on-jdk11
branch
from
6e1aa66 to
157a444
Compare
Okay, I split out the changes. This issue is just the POM change. |
madrob
reviewed
Jan 4, 2022
| </maven.build.timestamp.format> | ||
| <buildDate>${maven.build.timestamp}</buildDate> | ||
| <!-- these two control the Java language version and JVM runtime version supported --> | ||
| <compileSource>1.8</compileSource> |
There was a problem hiding this comment.
I believe that compile source and target allow setting 8 in addition to 1.8 while release requires 8 - can we standardize on a single value for all of these instead of have both 1.8 and 8 around?
There was a problem hiding this comment.
|
It's never as simple as that... |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
I'm pretty sure this will not work with today's version of JDK11 ; we appear to be blocked by JDK-8214165. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.