Skip to content

HBASE-26541 hbase-protocol-shaded not buildable on M1 MacOSX #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HBASE-26541 hbase-protocol-shaded not buildable on M1 MacOSX #3922

wants to merge 1 commit into from

Conversation

@apurtell
Copy link
Contributor

@apurtell apurtell commented Dec 6, 2021 •
edited
Loading

I needed to make some changes to get hbase-protocol-shaded building on an M1 mac.

  • Upgrade internal.protobuf.version to 3.17.3.

@apurtell apurtell requested review from Apache9 and busbey December 6, 2021 19:08
@apurtell apurtell changed the title HBASE-26541 hbase-shaded-protobuf not buildable on M1 MacOSX HBASE-26541 hbase-protocol-shaded not buildable on M1 MacOSX Dec 6, 2021
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 30s master passed
+1 💚 compile 0m 50s master passed
+1 💚 shadedjars 9m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 17s the patch passed
+1 💚 compile 0m 49s the patch passed
+1 💚 javac 0m 49s the patch passed
-1 ❌ shadedjars 3m 22s patch has 10 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 0m 49s hbase-protocol-shaded in the patch passed.
26m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3922
Optional Tests javac javadoc unit shadedjars compile
uname Linux 277c704b2920 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d9315fa
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/testReport/
Max. process+thread count 65 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded U: hbase-protocol-shaded
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 53s master passed
+1 💚 compile 1m 8s master passed
+1 💚 shadedjars 9m 38s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 39s the patch passed
+1 💚 compile 1m 15s the patch passed
+1 💚 javac 1m 15s the patch passed
-1 ❌ shadedjars 3m 49s patch has 10 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s the patch passed
_ Other Tests _
+1 💚 unit 1m 11s hbase-protocol-shaded in the patch passed.
31m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3922
Optional Tests javac javadoc unit shadedjars compile
uname Linux c41cd44a266b 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d9315fa
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/testReport/
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded U: hbase-protocol-shaded
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 16s master passed
+1 💚 compile 1m 29s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 48s the patch passed
+1 💚 compile 1m 31s the patch passed
+1 💚 cc 1m 31s the patch passed
+1 💚 javac 1m 31s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 19m 28s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 hbaseprotoc 0m 58s the patch passed
_ Other Tests _
-1 ❌ asflicense 0m 16s The patch generated 1 ASF License warnings.
40m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3922
Optional Tests dupname asflicense javac hadoopcheck xml compile cc hbaseprotoc prototool
uname Linux b1dc2cec6258 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d9315fa
Default Java AdoptOpenJDK-1.8.0_282-b08
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 95 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded U: hbase-protocol-shaded
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Dec 7, 2021

I replied on jira, we need more information on the failure message, as at least we do have the any.proto in the shaded protobuf jar...

@apurtell
Copy link
Contributor Author

apurtell commented Dec 7, 2021 •
edited
Loading

See https://issues.apache.org/jira/browse/HBASE-26541?focusedCommentId=17454738&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17454738

Going through this again (first I rm -rf ~/.m2/repository/com/google), it seems just the version change is enough. I have updated the PRs.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 44s master passed
+1 💚 compile 2m 15s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 2m 9s the patch passed
+1 💚 javac 2m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 19m 56s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
42m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3922
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux b62252a50260 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ca3ba49
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 5m 20s master passed
+1 💚 compile 1m 27s master passed
+1 💚 shadedjars 10m 34s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 5m 7s the patch passed
+1 💚 compile 1m 24s the patch passed
+1 💚 javac 1m 24s the patch passed
+1 💚 shadedjars 10m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 44s the patch passed
_ Other Tests _
+1 💚 unit 0m 58s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 39s hbase-examples in the patch passed.
42m 50s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3922
Optional Tests javac javadoc unit shadedjars compile
uname Linux 84d96fd4a62c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ca3ba49
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/testReport/
Max. process+thread count 1847 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 6m 35s master passed
+1 💚 compile 1m 55s master passed
+1 💚 shadedjars 12m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 44s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 6m 6s the patch passed
+1 💚 compile 1m 54s the patch passed
+1 💚 javac 1m 54s the patch passed
+1 💚 shadedjars 11m 48s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s the patch passed
_ Other Tests _
+1 💚 unit 1m 19s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 52s hbase-examples in the patch passed.
47m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3922
Optional Tests javac javadoc unit shadedjars compile
uname Linux add5f81a90c1 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ca3ba49
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/testReport/
Max. process+thread count 2086 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3922/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

apurtell commented Dec 9, 2021

This is required for compilation of HBase sources on Mac aarch64. I am committing this because as a committer I am entitled to a code base that will compile for me. Revert if you disagree.

@apurtell apurtell closed this Dec 9, 2021
@Apache9
Copy link
Contributor

Apache9 commented Dec 9, 2021

Ah, sorry to be late here. I'm +1 on this PR. Thanks Andrew for fixing this on M1. I think there will be more and more developers using M1 MBP to it is important to make sure hbase can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Awaiting requested review from Apache9

@busbey busbey Awaiting requested review from busbey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apurtell @Apache-HBase @Apache9