HBASE-26462 Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure #3921

2005hithlj · 2021-12-05T15:54:48Z

https://issues.apache.org/jira/browse/HBASE-26462

… CloneSnapshotProcedure and RestoreSnapshotProcedure

Apache-HBase · 2021-12-05T16:59:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 3s	master passed
+1 💚	compile	4m 42s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	spotbugs	6m 8s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	4m 41s	the patch passed
+1 💚	cc	4m 41s	the patch passed
+1 💚	javac	4m 41s	the patch passed
+1 💚	checkstyle	1m 15s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	19m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 43s	the patch passed
+1 💚	spotbugs	6m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		63m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3921
Optional Tests	dupname asflicense cc hbaseprotoc prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 1bc50771ac77 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcd622d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-05T18:56:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 40s	master passed
+1 💚	compile	2m 13s	master passed
+1 💚	shadedjars	8m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	2m 12s	the patch passed
+1 💚	javac	2m 12s	the patch passed
+1 💚	shadedjars	8m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 59s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	141m 9s	hbase-server in the patch passed.
		181m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3921
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 12485cab12ec 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcd622d`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/testReport/
Max. process+thread count	4634 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-05T20:29:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 52s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 29s	master passed
+1 💚	compile	1m 54s	master passed
+1 💚	shadedjars	9m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 38s	the patch passed
+1 💚	compile	2m 17s	the patch passed
+1 💚	javac	2m 17s	the patch passed
+1 💚	shadedjars	10m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 51s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	228m 36s	hbase-server in the patch passed.
		273m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3921
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux e1db9722097f 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcd622d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/testReport/
Max. process+thread count	2787 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Overall LGTM. Please fix the minor nits and also the whitespace issues.

Thanks.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java

...-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java

carp84

Thanks for the contribution @2005hithlj . The latest changes LGTM. Let's see what the pre-commit robot says.

Apache-HBase · 2021-12-06T05:51:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 1s	master passed
+1 💚	compile	4m 46s	master passed
+1 💚	checkstyle	1m 16s	master passed
+1 💚	spotbugs	6m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	4m 37s	the patch passed
+1 💚	cc	4m 37s	the patch passed
+1 💚	javac	4m 37s	the patch passed
+1 💚	checkstyle	1m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 18s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	hbaseprotoc	1m 41s	the patch passed
+1 💚	spotbugs	6m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		63m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3921
Optional Tests	dupname asflicense cc hbaseprotoc prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 9367fec04bb2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcd622d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-06T07:51:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 11s	master passed
+1 💚	compile	1m 55s	master passed
+1 💚	shadedjars	8m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	1m 46s	the patch passed
+1 💚	javac	1m 46s	the patch passed
+1 💚	shadedjars	8m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 49s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	148m 12s	hbase-server in the patch passed.
		183m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3921
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux 7751904e3a27 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcd622d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/testReport/
Max. process+thread count	4488 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-12-06T08:55:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 14s	master passed
+1 💚	compile	2m 22s	master passed
+1 💚	shadedjars	9m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 4s	the patch passed
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	shadedjars	9m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 5s	hbase-protocol-shaded in the patch passed.
-1 ❌	unit	206m 50s	hbase-server in the patch failed.
		247m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3921
Optional Tests	unit javac javadoc shadedjars compile
uname	Linux d4b7d2cce171 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dcd622d`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/testReport/
Max. process+thread count	3299 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3921/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2021-12-06T12:13:41Z

Hi, @Apache9 , the UT TestProcedureAdmin#testGetProcedure failed. This UT does not seem to have anything to do with my modification, and in my HBase compile environment, it can be executed successfully. Is this an unstable UT?

Apache9 · 2021-12-06T14:15:10Z

The UT itself passed in the second run, seems the problem is that the JVM crashed, not sure what is the problem, maybe by OOM killer?

Anyway, let's merge this PR.

… CloneSnapshotProcedure and RestoreSnapshotProcedure (#3921) Signed-off-by: Yu Li <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

… CloneSnapshotProcedure and RestoreSnapshotProcedure (apache#3921) Signed-off-by: Yu Li <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

HBASE-26462 Should persist restoreAcl flag in the procedure state for…

ff62798

… CloneSnapshotProcedure and RestoreSnapshotProcedure

Apache9 reviewed Dec 6, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java Show resolved Hide resolved

...-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java Show resolved Hide resolved

fix whitespace error and add RestrictedApi annotation

74930df

carp84 self-requested a review December 6, 2021 04:49

carp84 approved these changes Dec 6, 2021

View reviewed changes

Apache9 approved these changes Dec 6, 2021

View reviewed changes

Apache9 merged commit 9cf224d into apache:master Dec 6, 2021

2005hithlj deleted the HBASE-26462 branch December 7, 2021 02:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

HBASE-26462 Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure #3921

HBASE-26462 Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure #3921

Uh oh!

2005hithlj commented Dec 5, 2021

Uh oh!

Apache-HBase commented Dec 5, 2021

Uh oh!

Apache-HBase commented Dec 5, 2021

Uh oh!

Apache-HBase commented Dec 5, 2021

Uh oh!

Apache9 left a comment

Uh oh!

Uh oh!

Uh oh!

carp84 left a comment

Uh oh!

Apache-HBase commented Dec 6, 2021

Uh oh!

Apache-HBase commented Dec 6, 2021

Uh oh!

Apache-HBase commented Dec 6, 2021

Uh oh!

2005hithlj commented Dec 6, 2021

Uh oh!

Apache9 commented Dec 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

HBASE-26462 Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure #3921

HBASE-26462 Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure #3921

Uh oh!

Conversation

2005hithlj commented Dec 5, 2021

Uh oh!

Apache-HBase commented Dec 5, 2021

Uh oh!

Apache-HBase commented Dec 5, 2021

Uh oh!

Apache-HBase commented Dec 5, 2021

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

carp84 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Dec 6, 2021

Uh oh!

Apache-HBase commented Dec 6, 2021

Uh oh!

Apache-HBase commented Dec 6, 2021

Uh oh!

2005hithlj commented Dec 6, 2021

Uh oh!

Apache9 commented Dec 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants