Skip to content

HBASE-26512 Make timestamp format configurable in HBase shell scan ou… #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HBASE-26512 Make timestamp format configurable in HBase shell scan ou… #3894

wants to merge 1 commit into from

Conversation

@stoty
Copy link
Contributor

@stoty stoty commented Nov 29, 2021

…tput

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 0m 51s master passed
+1 💚 shadedjars 10m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 28s the patch passed
+1 💚 compile 0m 54s the patch passed
+1 💚 javac 0m 54s the patch passed
+1 💚 shadedjars 8m 35s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s the patch passed
_ Other Tests _
+1 💚 unit 1m 53s hbase-common in the patch passed.
+1 💚 unit 7m 3s hbase-shell in the patch passed.
42m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3894
Optional Tests javac javadoc unit shadedjars compile
uname Linux d2866511069f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f108997
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/testReport/
Max. process+thread count 2334 (vs. ulimit of 30000)
modules C: hbase-common hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 5m 24s master passed
+1 💚 compile 0m 51s master passed
+1 💚 shadedjars 9m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 5m 45s the patch passed
+1 💚 compile 0m 59s the patch passed
+1 💚 javac 0m 59s the patch passed
+1 💚 shadedjars 9m 36s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s the patch passed
_ Other Tests _
+1 💚 unit 2m 19s hbase-common in the patch passed.
+1 💚 unit 8m 7s hbase-shell in the patch passed.
46m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3894
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4c7cc7119115 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f108997
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/testReport/
Max. process+thread count 1670 (vs. ulimit of 30000)
modules C: hbase-common hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 5m 17s master passed
+1 💚 compile 1m 32s master passed
+1 💚 checkstyle 0m 43s master passed
+1 💚 spotbugs 1m 2s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 2s the patch passed
+1 💚 compile 1m 29s the patch passed
+1 💚 javac 1m 29s the patch passed
+1 💚 checkstyle 0m 45s the patch passed
-0 ⚠️ rubocop 0m 7s The patch generated 6 new + 130 unchanged - 2 fixed = 136 total (was 132)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 24m 53s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotbugs 1m 11s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
54m 36s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3894
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
uname Linux 83aa4cfb83bc 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f108997
Default Java AdoptOpenJDK-1.8.0_282-b08
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3894/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelser
Copy link
Member

Also, fyi @cuibo01 since you had made the change in #2351

joshelser
joshelser approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and to the point. Defaults to the human-readable timestamp. Looks great to me.

Will give Stack, Bo, and others a chance to comment since coming off a holiday week.

@joshelser
Copy link
Member

Just ran this in pseudo-local mode and it looks good to me. Pushing.

@joshelser
Copy link
Member

Merged this into master, branch-2, and branch-2.4

@joshelser joshelser closed this Dec 1, 2021
@tomerr90
Copy link

tomerr90 commented Jul 6, 2025

Apologies if thats not the place for that, been trying to set it for a specific session of hbase shell (using HBASE_OPTS, and some other methods) and couldnt get it to work, where am I supposed to set it?

@petersomogyi
Copy link
Contributor

@tomerr90 Try staring the HBase shell with the -Dconfig=value parameter instead.

hbase shell -Dhbase.shell.timestamp.format.epoch=true

@tomerr90
Copy link

I can swear I tried it and it didnt, but works now...
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshelser joshelser joshelser approved these changes

@petersomogyi petersomogyi petersomogyi approved these changes

@pankaj72981 pankaj72981 Awaiting requested review from pankaj72981

@saintstack saintstack Awaiting requested review from saintstack

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stoty @Apache-HBase @joshelser @tomerr90 @petersomogyi