HBASE-26459 HMaster should move non-meta region only if meta is ONLINE #3875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
@YutSean Can we add some tests ? |
|
OK, let me try. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed UT passed locally. It is a little bit flaky. |
virajjasani
reviewed
Nov 26, 2021
Comment on lines
1858
to
1860
| LOG.info("Moving " + rp + " failed. " + | ||
| "While there is still meta regions in transition after " + | ||
| timeoutWaitMetaRegionAssignment + "ms waiting."); |
There was a problem hiding this comment.
I think ERROR log would be better. Also, how about this error message?
LOG.error("This is fail-fast of the region move because hbase:meta region is in transition. Failed region move info: " + rp);
There was a problem hiding this comment.
Looks better. Changed in the latest commit.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
Show resolved
Hide resolved
| public static final String HBASE_MASTER_WAITING_META_ASSIGNMENT_TIMEOUT = | ||
| "hbase.master.waiting.meta.assignment.timeout"; | ||
|
|
||
| public static final long HBASE_MASTER_WAITING_META_ASSIGNMENT_TIMEOUT_DEFAULT = 5000; |
There was a problem hiding this comment.
Let's keep it 10000 (10 s)?
There was a problem hiding this comment.
Not sure if 10s is better. Actually, 5s is my intuition. Have changed in the latest commit. But could you explain the reason to change to 10s a little bit?
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Nov 26, 2021
| if (assignmentManager.getRegionStates().isMetaRegionInTransition()) { | ||
| LOG.error("This is fail-fast of the region move because " | ||
| + "hbase:meta region is in transition. Failed region move info: " + rp); | ||
| return; |
There was a problem hiding this comment.
I think we can throw HBaseIOException here since this is fail-fast scenario?
There was a problem hiding this comment.
Right, exception could be detected by the client. Have changed to throw exception in the latest commit.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Overall looks good. Thanks @YutSean. Can you please also take care of the recent whitespace warning?
|
Fixed in the latest commit. Let's see if it is ok this time. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Nov 30, 2021
virajjasani
reviewed
Dec 3, 2021
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Dec 3, 2021
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-26459