HBASE-26383 HBCK incorrectly reports inconsistencies for recently split regions following a master failover #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it regions following a master failover A regression was introduced by HBASE-25847 which changed regionInfo#isParentSplit to regionState#isSplit. The region state after restart is CLOSED instead of SPLIT. We need to check both regionState and regionInfo for split status.
virajjasani
approved these changes
Oct 20, 2021
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Oct 20, 2021
There was a problem hiding this comment.
LGTM
Was wondering why the change over in HBASE-25847 in the first place @apurtell (If you remember...). I think your change would have been fine only we lose RegionState on Master restart (per Duo comment here
turned up by Benoit's Boris). Thanks.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thanks for the review @virajjasani |
asfgit
pushed a commit
that referenced
this pull request
Oct 20, 2021
…it regions following a master failover (#3775) A regression was introduced by HBASE-25847 which changed regionInfo#isParentSplit to regionState#isSplit. The region state after restart is CLOSED instead of SPLIT. We need to check both regionState and regionInfo for split status. Signed-off-by: Viraj Jasani <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Oct 20, 2021
…it regions following a master failover (#3775) A regression was introduced by HBASE-25847 which changed regionInfo#isParentSplit to regionState#isSplit. The region state after restart is CLOSED instead of SPLIT. We need to check both regionState and regionInfo for split status. Signed-off-by: Viraj Jasani <[email protected]>
|
Sorry I missed your comment @saintstack .
I do not remember. Given the related changes, without that additional change the new log lines were contrary to expectation. It looked like a bug, per my comments on the issue. |
|
@saintstack I am going to release a 2.4.8 with this merged PR included. You'd like instead to see some additional work done here or a revert of the original change rather than this addition, just say. |
|
Thanks for the PR @apurtell . I think this change will do away with the confusing split parent reporting as inconsistent (after a Master restart). That'll help. Can work on the bigger issue of new Master not faithfully reproducing old Master's in-memory state in another PR/JIRA. Thanks (I kicked Benoit and Boris for comment...) |
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…it regions following a master failover (apache#3775) A regression was introduced by HBASE-25847 which changed regionInfo#isParentSplit to regionState#isSplit. The region state after restart is CLOSED instead of SPLIT. We need to check both regionState and regionInfo for split status. Signed-off-by: Viraj Jasani <[email protected]> Ref: CDPD-30762 Author: Andrew Purtell Reason: Bug (cherry picked from commit 4149459) Change-Id: I3ce08ce629bfb4b263ebb37efcef2a7de06ed64d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced by HBASE-25847 which changed regionInfo#isParentSplit to regionState#isSplit. The region state after restart is CLOSED instead of SPLIT. We need to check both regionState and regionInfo for split status.