Skip to content

HBASE-26364 TestThriftServer is failing 100% in our flaky test job #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2021
Merged

HBASE-26364 TestThriftServer is failing 100% in our flaky test job #3759

merged 2 commits into from
Oct 18, 2021

Conversation

@wchevreuil
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 52s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 31s master passed
+1 💚 compile 0m 33s master passed
+1 💚 shadedjars 8m 59s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 19s the patch passed
+1 💚 compile 0m 34s the patch passed
+1 💚 javac 0m 34s the patch passed
+1 💚 shadedjars 9m 4s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 34s the patch passed
_ Other Tests _
+1 💚 unit 7m 25s hbase-thrift in the patch passed.
43m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3759
Optional Tests javac javadoc unit shadedjars compile
uname Linux 45f8d7cae055 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1020fe1
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/testReport/
Max. process+thread count 1375 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 33s master passed
+1 💚 compile 1m 0s master passed
+1 💚 checkstyle 0m 45s master passed
+1 💚 spotbugs 1m 37s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 17s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
-0 ⚠️ checkstyle 0m 43s hbase-thrift: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 21m 32s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 42s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
47m 36s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3759
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux d651b1287b6a 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1020fe1
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 6m 18s master passed
+1 💚 compile 0m 54s master passed
+1 💚 shadedjars 10m 28s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 6m 2s the patch passed
+1 💚 compile 0m 50s the patch passed
+1 💚 javac 0m 50s the patch passed
+1 💚 shadedjars 10m 41s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 15s the patch passed
_ Other Tests _
+1 💚 unit 8m 26s hbase-thrift in the patch passed.
48m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3759
Optional Tests javac javadoc unit shadedjars compile
uname Linux d18e08e6fb4d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1020fe1
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/testReport/
Max. process+thread count 1419 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 1s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 13s master passed
+1 💚 compile 0m 33s master passed
+1 💚 shadedjars 9m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 34s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 20s the patch passed
+1 💚 compile 0m 33s the patch passed
+1 💚 javac 0m 33s the patch passed
+1 💚 shadedjars 9m 8s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 34s the patch passed
_ Other Tests _
+1 💚 unit 7m 21s hbase-thrift in the patch passed.
38m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3759
Optional Tests javac javadoc unit shadedjars compile
uname Linux 130e1a750dbf 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1020fe1
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/testReport/
Max. process+thread count 1376 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 15s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 12s master passed
+1 💚 compile 0m 57s master passed
+1 💚 checkstyle 0m 46s master passed
+1 💚 spotbugs 1m 29s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 14s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
-0 ⚠️ checkstyle 0m 44s hbase-thrift: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 21m 21s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 41s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
46m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3759
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux f3a286dfe29b 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1020fe1
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Oct 18, 2021

Mind explaining a bit about the PR?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 9s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 53s master passed
+1 💚 compile 0m 50s master passed
+1 💚 shadedjars 10m 36s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 59s the patch passed
+1 💚 compile 0m 52s the patch passed
+1 💚 javac 0m 52s the patch passed
+1 💚 shadedjars 10m 37s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 15s the patch passed
_ Other Tests _
+1 💚 unit 8m 29s hbase-thrift in the patch passed.
48m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3759
Optional Tests javac javadoc unit shadedjars compile
uname Linux 48853888127d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1020fe1
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/testReport/
Max. process+thread count 1416 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3759/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
Copy link
Contributor Author

Mind explaining a bit about the PR?

This testMetricsWithException was adding a table, but not removing it at the end. This causes tests that call createTestTable fail, if those are run after testMetricsWithException. This PR adds a try/finally clause to testMetricsWithException, removing the created table at the finally block.

@wchevreuil wchevreuil merged commit 4454c2f into apache:master Oct 18, 2021
wchevreuil added a commit that referenced this pull request Oct 18, 2021
@wchevreuil
HBASE-26364 TestThriftServer is failing 100% in our flaky test job (#…
be9877e 
…3759)

Signed-off-by: Xiaolin Ha <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 4454c2f)
wchevreuil added a commit that referenced this pull request Oct 18, 2021
@wchevreuil
HBASE-26364 TestThriftServer is failing 100% in our flaky test job (#…
7bbbd3d 
…3759)

Signed-off-by: Xiaolin Ha <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 4454c2f)
wchevreuil added a commit that referenced this pull request Oct 18, 2021
@wchevreuil
HBASE-26364 TestThriftServer is failing 100% in our flaky test job (#…
5589744 
…3759)

Signed-off-by: Xiaolin Ha <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 4454c2f)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@wchevreuil @stoty
HBASE-26364 TestThriftServer is failing 100% in our flaky test job (a…
04e7c86 
…pache#3759)

Signed-off-by: Xiaolin Ha <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 4454c2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Apache9 approved these changes

@sunhelly sunhelly sunhelly approved these changes

@petersomogyi petersomogyi Awaiting requested review from petersomogyi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wchevreuil @Apache-HBase @Apache9 @sunhelly