Skip to content

HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2021
Merged

HBASE-25469 Add detailed RIT info in JSON format for consumption as metrics #3535

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
18c5556
HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT …
caroliney14 Jul 27, 2021
1a78a75
address review comments
caroliney14 Aug 2, 2021
a6d234b
change link
caroliney14 Aug 2, 2021
1538722
consolidiate into rit.jsp file
caroliney14 Aug 3, 2021
cc426dc
add filters
caroliney14 Aug 3, 2021
83dfb18
format
caroliney14 Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion hbase-server/src/main/resources/hbase-webapps/master/rits.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,17 @@
import="static org.apache.commons.lang3.StringEscapeUtils.escapeXml"
import="java.util.Collections"
import="java.util.Comparator"
import="java.util.ArrayList"
import="java.util.List"
import="java.util.HashMap"
import="java.util.Map"
import="java.util.stream.Collectors"
import="org.apache.hadoop.hbase.master.HMaster"
import="org.apache.hadoop.hbase.master.RegionState"
import="org.apache.hadoop.hbase.master.assignment.RegionStateNode"
import="org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure"
import="org.apache.hadoop.hbase.util.GsonUtil"
import="org.apache.hbase.thirdparty.com.google.gson.Gson"
%>
<%
HMaster master = (HMaster) getServletContext().getAttribute(HMaster.MASTER);
Expand Down Expand Up @@ -69,6 +75,7 @@
<div class="page-header">
<a href="/rits.jsp?format=txt&filter=region&table=<%=table%>&state=<%=state%>" class="btn btn-primary">Regions in text format</a>
<a href="/rits.jsp?format=txt&filter=procedure&table=<%=table%>&state=<%=state%>" class="btn btn-info">Procedures in text format</a>
<a href="/rits.jsp?format=json&table=<%=table%>&state=<%=state%>" class="btn btn-info">RIT info as JSON</a>
<p>regions and procedures in text format can be copied and passed to command-line utils such as hbck2</p>
</div>
</div>
Expand All @@ -79,14 +86,18 @@
<th>Region</th>
<th>Table</th>
<th>RegionState</th>
<th>Server</th>
<th>Procedure</th>
<th>ProcedureState</th>
<th>Start Time</th>
<th>Duration (ms)</th>
</tr>
<% for (RegionStateNode regionStateNode : rit) { %>
<tr>
<td><%= regionStateNode.getRegionInfo().getEncodedName() %></td>
<td><%= regionStateNode.getRegionInfo().getTable() %></td>
<td><%= regionStateNode.getState() %></td>
<td><%= regionStateNode.getRegionLocation().getServerName() %></td>
<%
TransitRegionStateProcedure procedure = regionStateNode.getProcedure();

Expand All @@ -98,16 +109,47 @@
<td><%= procedure.getProcId() %></td>
<td><%= escapeXml(procedure.getState().toString() + (procedure.isBypass() ? "(Bypassed)" : "")) %></td>
<% } %>

<% RegionState rs = regionStateNode.toRegionState(); %>
<td><%= rs.getStamp() %></td>
<td><%= System.currentTimeMillis() - rs.getStamp() %></td>
</tr>
<% } %>
<p><%= rit.size() %> region(s) in transition.</p>
</table>
<% } else { %>
<p> no region in transition right now. </p>
<% } %>

</div>
<jsp:include page="footer.jsp" />
<% } else if (format.equals("json")) { %>
<%
Gson GSON = GsonUtil.createGson().create();
Map<String, List<Map<String, Object>>> map = new HashMap<>();
List<Map<String, Object>> rits = new ArrayList<>();
map.put("rits", rits);
for (RegionStateNode regionStateNode : rit) {
Map<String, Object> r = new HashMap<>();
r.put("region", regionStateNode.getRegionInfo().getEncodedName());
r.put("table", regionStateNode.getRegionInfo().getTable().getNameAsString());
r.put("state", regionStateNode.getState());
r.put("server", regionStateNode.getRegionLocation().getServerName());

TransitRegionStateProcedure procedure = regionStateNode.getProcedure();
if (procedure != null) {
r.put("procedureId", procedure.getProcId());
r.put("procedureState", procedure.getState().toString());
}

RegionState rs = regionStateNode.toRegionState();
r.put("startTime", rs.getStamp());
r.put("duration", System.currentTimeMillis() - rs.getStamp());

rits.add(r);
}
%>
<%= GSON.toJson(map) %>
<% } else { %>
<div class="container-fluid content">
<div class="row">
Expand All @@ -127,4 +169,4 @@
</p>
</div>
</div>
<% } %>
<% } %>