Skip to content

HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 16, 2021
Merged

HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache #3473

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
613b577
HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when us…
YutSean Jul 12, 2021
87997c7
Fix a logic bug.
YutSean Jul 13, 2021
6c79aea
Add metric update in containsBlock method
YutSean Jul 13, 2021
7e07fd7
Refine the metrics update
YutSean Jul 13, 2021
11724fa
Refine the metrics update
YutSean Jul 13, 2021
2f70542
trigger QA
YutSean Jul 13, 2021
192b212
Refine the L1 miss metric in combinedBC
YutSean Jul 14, 2021
ad2f086
Refine the metric update condition
YutSean Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,13 @@ public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching,
// we end up calling l2Cache.getBlock.
// We are not in a position to exactly look at LRU cache or BC as BlockType may not be getting
// passed always.
return l1Cache.containsBlock(cacheKey)?
boolean existInL1 = l1Cache.containsBlock(cacheKey);
if (!existInL1 && updateCacheMetrics && !repeat) {
// If the block does not exist in L1, the containsBlock should be counted as one miss.
l1Cache.getStats().miss(caching, cacheKey.isPrimary(), cacheKey.getBlockType());
}

return existInL1 ?
l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics):
l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics);
}
Expand Down