Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jun 27, 2019

…should skip store files for unknown column families

@Apache9 Apache9 requested a review from infraio June 27, 2019 03:47
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 247 master passed
+1 compile 52 master passed
+1 checkstyle 65 master passed
+1 shadedjars 261 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 215 master passed
+1 javadoc 32 master passed
_ Patch Compile Tests _
+1 mvninstall 237 the patch passed
+1 compile 53 the patch passed
+1 javac 53 the patch passed
+1 checkstyle 68 hbase-server: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 268 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 728 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 209 the patch passed
+1 javadoc 30 the patch passed
_ Other Tests _
-1 unit 8367 hbase-server in the patch failed.
+1 asflicense 24 The patch does not generate ASF License warnings.
11194
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestIgnoreUnknownFamily
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/artifact/out/Dockerfile
GITHUB PR #344
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 77178c255710 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 0198868
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/testReport/
Max. process+thread count 4559 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…should skip store files for unknown column families
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 72 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 248 master passed
+1 compile 53 master passed
+1 checkstyle 74 master passed
+1 shadedjars 269 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 213 master passed
+1 javadoc 33 master passed
_ Patch Compile Tests _
+1 mvninstall 236 the patch passed
+1 compile 52 the patch passed
+1 javac 52 the patch passed
+1 checkstyle 77 hbase-server: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 271 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 731 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 228 the patch passed
+1 javadoc 32 the patch passed
_ Other Tests _
-1 unit 13020 hbase-server in the patch failed.
+1 asflicense 25 The patch does not generate ASF License warnings.
15955
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/artifact/out/Dockerfile
GITHUB PR #344
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux baff8c16fd33 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 0198868
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/testReport/
Max. process+thread count 4790 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-344/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 94d5419 into apache:master Jun 27, 2019
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)

Signed-off-by: Guanghao Zhang <[email protected]>
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)

Signed-off-by: Guanghao Zhang <[email protected]>
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)

Signed-off-by: Guanghao Zhang <[email protected]>
asfgit pushed a commit that referenced this pull request Jun 27, 2019
…should skip store files for unknown column families (#344)

Signed-off-by: Guanghao Zhang <[email protected]>
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test. Fails w/o this patch?

@saintstack
Copy link
Contributor

Oh. Ignore. Missed that its merged.

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Jul 3, 2019
…should skip store files for unknown column families (apache#344)

Signed-off-by: Guanghao Zhang <[email protected]>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…should skip store files for unknown column families (apache#344)

Signed-off-by: Guanghao Zhang <[email protected]>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…should skip store files for unknown column families (apache#344)

Signed-off-by: Guanghao Zhang <[email protected]>
(cherry picked from commit 98aa24a)

Change-Id: Ia6b3440e600140edf202963b10dbc09650900492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants