HBASE-25720 Sync WAL stuck when prepare flush cache will prevent flus… #3140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
May 21, 2021
| doSyncOfUnflushedWALChanges(wal, getRegionInfo()); | ||
| } catch (Throwable t) { | ||
| status.abort("Sync unflushed WAL changes failed: " + StringUtils.stringifyException(t)); | ||
| fatalForFlushCache(t); |
Contributor
There was a problem hiding this comment.
Mind explaining a bit why here we need to abort the regionserver? We do not need to abort the regionserver when hitting IOException above?
Contributor
Author
There was a problem hiding this comment.
The IOException thrown above is not caused by syncing WAL, only the sync failure should abort the RS as early as possible. And if we only allow aborting RS in the commit step of flushing cache, there will always exit the circumstance that OOM kill, because all failures in the previous preparing step of flushing cache only aborted the flush process, all flushing can not go to the commit step.
Contributor
Author
There was a problem hiding this comment.
@Apache9 We currently only abort RS when there are critical problems, such as the WAL stuck? The above IOExceptions can only abort the flush in mem and should not prevent the next flushes, right? Here the abort is caused by the wal stucks who are ahead of the committing flush wal sync stucks. What do you think?
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hing cache and cause OOM