Skip to content

Conversation

@javierluca
Copy link
Contributor

This is just a very minor improvement over #2973 (that was actually pushed by @saintstack at 59ec375).

However, I like the approach to use "localhost" as the argument hostname for the purpose instead of having to pass the fqdn itself, so I would like to add such option (see #3048).

fi
if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
local=true
hostname=$localhostname
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, passing "localhost" to regionserver.sh is meant to be used in pseudo-distributed environments. See:

And it would use fixed ports:

if [ "$regionservers" = "localhost" ]; then
HBASE_REGIONSERVER_ARGS="\
-Dhbase.regionserver.port=16020 \
-Dhbase.regionserver.info.port=16030"

Since I want to avoid that, let me reassign hostname to the fqdn here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javierluca . Thanks for digging in here.

Thanks for turning-up the 'overloading' of 'localhost'.

Above looks reasonable. Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true: i.e. do we need lines #108-110 in above now you've added #111-114?

Lets open new issue for this further discussion so we don't muddle JIRA+PR intent.

Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, on the ports for regionservers.sh, I think its just lazyness that they are hardcoded. Can change that in another issue.... Use HBASE_RS_BASE_PORT and HBASE_RS_INFO_BASE_PORT

Copy link
Contributor Author

@javierluca javierluca Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true

Ah no, that is my mistake. Sorry about that, we should remove the first check.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
2m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3054
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux 6aca4e82b46a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d74ae15
Max. process+thread count 49 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/console
versions git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3054
Optional Tests
uname Linux e25aabdc729d 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d74ae15
Max. process+thread count 51 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
2m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3054
Optional Tests
uname Linux b5673ef1a7de 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d74ae15
Max. process+thread count 46 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack saintstack changed the title HBOPS-25594 Make easier to use graceful_stop on localhost mode HBASE-25594 Make easier to use graceful_stop on localhost mode Mar 16, 2021
@saintstack saintstack merged commit 0cead10 into apache:master Mar 18, 2021
saintstack pushed a commit that referenced this pull request Mar 18, 2021
saintstack pushed a commit that referenced this pull request Mar 18, 2021
saintstack pushed a commit that referenced this pull request Mar 18, 2021
saintstack added a commit that referenced this pull request Mar 18, 2021
#3054)"

This reverts commit 728d4f5.

Reverted because it an addendum and main patch did not land on this
branch so removing.
petersomogyi added a commit that referenced this pull request Mar 19, 2021
petersomogyi pushed a commit that referenced this pull request Mar 19, 2021
petersomogyi added a commit that referenced this pull request Mar 19, 2021
petersomogyi pushed a commit that referenced this pull request Mar 19, 2021
petersomogyi added a commit that referenced this pull request Mar 19, 2021
petersomogyi pushed a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants