-
Couldn't load subscription status.
- Fork 3.4k
HBASE-25594 Make easier to use graceful_stop on localhost mode #3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| fi | ||
| if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then | ||
| local=true | ||
| hostname=$localhostname |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, passing "localhost" to regionserver.sh is meant to be used in pseudo-distributed environments. See:
- https://issues.apache.org/jira/browse/HBASE-15924?focusedCommentId=16410243&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16410243
- https://issues.apache.org/jira/browse/HBASE-20130
And it would use fixed ports:
Lines 61 to 64 in d74ae15
| if [ "$regionservers" = "localhost" ]; then | |
| HBASE_REGIONSERVER_ARGS="\ | |
| -Dhbase.regionserver.port=16020 \ | |
| -Dhbase.regionserver.info.port=16030" |
Since I want to avoid that, let me reassign hostname to the fqdn here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @javierluca . Thanks for digging in here.
Thanks for turning-up the 'overloading' of 'localhost'.
Above looks reasonable. Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true: i.e. do we need lines #108-110 in above now you've added #111-114?
Lets open new issue for this further discussion so we don't muddle JIRA+PR intent.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, on the ports for regionservers.sh, I think its just lazyness that they are hardcoded. Can change that in another issue.... Use HBASE_RS_BASE_PORT and HBASE_RS_INFO_BASE_PORT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true
Ah no, that is my mistake. Sorry about that, we should remove the first check.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
Co-authored-by: Javier <[email protected]>
This is just a very minor improvement over #2973 (that was actually pushed by @saintstack at 59ec375).
However, I like the approach to use "localhost" as the argument hostname for the purpose instead of having to pass the fqdn itself, so I would like to add such option (see #3048).