HBASE-25460 : Expose drainingServers as cluster metric #2995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Mar 2, 2021
Comment on lines
141
to
158
| @Override | ||
| public String getDrainingRegionServers() { | ||
| ServerManager serverManager = this.master.getServerManager(); | ||
| if (serverManager == null) { | ||
| return ""; | ||
| } | ||
| return StringUtils.join(serverManager.getDrainingServersList() , ";"); | ||
| } | ||
|
|
||
| @Override | ||
| public int getNumDrainingRegionServers() { | ||
| ServerManager serverManager = this.master.getServerManager(); | ||
| if (serverManager == null) { | ||
| return 0; | ||
| } | ||
| return serverManager.getDrainingServersList().size(); | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: good to reformat this code once for alignment
| metricsHelper.assertGauge("numRegionServers", 1 + (tablesOnMaster ? 1 : 0), masterSource); | ||
| metricsHelper.assertGauge("averageLoad", 1, masterSource); | ||
| metricsHelper.assertGauge("numDeadRegionServers", 0, masterSource); | ||
| metricsHelper.assertGauge( "numDrainingRegionServers", 0, masterSource); |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
Mar 4, 2021
Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Mar 4, 2021
Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Mar 4, 2021
Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Mar 4, 2021
Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Mar 4, 2021
Signed-off-by: Viraj Jasani <[email protected]>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
…pache#2995) Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit e5f32be) Change-Id: I332296e4892b4f36d063ae8a09f5a8b5d67951cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.