HBASE-25603 Add switch for compaction after bulkload #2982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Feb 24, 2021
| this.rsServices.getCompactionRequestor().requestCompaction(this, store, | ||
| "bulkload hfiles request compaction", Store.PRIORITY_USER + 1, | ||
| CompactionLifeCycleTracker.DUMMY, null); | ||
| if (conf.getBoolean(HConstants.COMPACTION_AFTER_BULKLOAD_ENABLE, false)) { |
There was a problem hiding this comment.
Shouldn't it be enabled by default, to keep consistent with previous behaviour?
There was a problem hiding this comment.
Yes,but I think it's better to set false by default, this feature will be enable only when user explicitly set it. Otherwise difficult to find this performance effect
There was a problem hiding this comment.
I agree with @wchevreuil that we'd better keep the old behavior by default, at least on branch-2. We could file a new issue to change it to false on master branch. WDYT?
There was a problem hiding this comment.
Yes, I totally agree
There was a problem hiding this comment.
@wchevreuil I have added in ref-guide section.
Apache9
reviewed
Mar 2, 2021
| this.rsServices.getCompactionRequestor().requestCompaction(this, store, | ||
| "bulkload hfiles request compaction", Store.PRIORITY_USER + 1, | ||
| CompactionLifeCycleTracker.DUMMY, null); | ||
| if (conf.getBoolean(HConstants.COMPACTION_AFTER_BULKLOAD_ENABLE, false)) { |
There was a problem hiding this comment.
I agree with @wchevreuil that we'd better keep the old behavior by default, at least on branch-2. We could file a new issue to change it to false on master branch. WDYT?
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Mar 2, 2021
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
nyl3532016
added a commit
that referenced
this pull request
Mar 4, 2021
Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when compaction after bulkload is enable, if bulkload is continuous, considerable compaction events will be triggered, which increase load, bring about performance impact