-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-25541: Setting the path to null when we dequeue the current log #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit to add some detail to the commit message to set the context.
| LOG.debug("EOF, closing {}", currentPath); | ||
| closeReader(); | ||
| logQueue.remove(); | ||
| setCurrentPath(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, can you add some detail to the commit message, I think it's subtle.
Looks like the issue is if openNextLog() throws, we want currentPath to be null rather than stale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have good context here, but is it possible to add a small test? That could help anyone get to know this bit better, it's fine though if it is too complicated to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got to know from @sandeepvinayak that writing test is complicated. We can skip it.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
#2959) Signed-off-by: Bharath Vissapragada <[email protected]>
#2959) Signed-off-by: Bharath Vissapragada <[email protected]>
#2959) Signed-off-by: Bharath Vissapragada <[email protected]>
#2959) Signed-off-by: Bharath Vissapragada <[email protected]>
#2959) Signed-off-by: Bharath Vissapragada <[email protected]>
apache#2959) Signed-off-by: Bharath Vissapragada <[email protected]>
apache#2959) Signed-off-by: Bharath Vissapragada <[email protected]>
apache#2959) Signed-off-by: Bharath Vissapragada <[email protected]> (cherry picked from commit ed9f8e6) Change-Id: I6d68df2f91a53fc8eae1a75bc63d847e0da2d63b
Currently, when we deque we do not reset the current wal path, and it blows up while opening the next log, the current path still points to previous wal which is not correct.