HBASE-23887 AdaptiveLRU cache #2934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pustota2009
changed the title
pustota2009
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
fix javadoc warn
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
dummy commit to re-run unit tests
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Feb 9, 2021
There was a problem hiding this comment.
Thanks for the PR @pustota2009 . Left some comments, please take a look
| private final AtomicLong count; | ||
|
|
||
| /** hard capacity limit */ | ||
| private float hardCapacityLimitFactor; |
| private long maxSize; | ||
|
|
||
| /** Approximate block size */ | ||
| private long blockSize; |
There was a problem hiding this comment.
Starting from blockSize till forceInMemory, all can be final
| } | ||
|
|
||
| // check the bounds | ||
| this.heavyEvictionCountLimit = heavyEvictionCountLimit < 0 ? 0 : heavyEvictionCountLimit; |
There was a problem hiding this comment.
nit: Math.max(heavyEvictionCountLimit, 0) ?
Comment on lines
441
to
442
| heavyEvictionOverheadCoefficient = heavyEvictionOverheadCoefficient < 0.001f | ||
| ? 0.001f : heavyEvictionOverheadCoefficient; |
There was a problem hiding this comment.
same here: Math.max(heavyEvictionOverheadCoefficient, 0.001f)
Comment on lines
706
to
719
| public int evictBlocksByHfileName(String hfileName) { | ||
| int numEvicted = 0; | ||
| for (BlockCacheKey key : map.keySet()) { | ||
| if (key.getHfileName().equals(hfileName)) { | ||
| if (evictBlock(key)) { | ||
| ++numEvicted; | ||
| } | ||
| } | ||
| } | ||
| if (victimHandler != null) { | ||
| numEvicted += victimHandler.evictBlocksByHfileName(hfileName); | ||
| } | ||
| return numEvicted; | ||
| } |
There was a problem hiding this comment.
This can be replaced by Stream.count() for simplicity:
public int evictBlocksByHfileName(String hfileName) {
int numEvicted = (int) map.keySet().stream().filter(key -> key.getHfileName().equals(hfileName))
.filter(this::evictBlock).count();
if (victimHandler != null) {
numEvicted += victimHandler.evictBlocksByHfileName(hfileName);
}
return numEvicted;
}
| EvictionThread evictionThread = cache.getEvictionThread(); | ||
| assertTrue(evictionThread != null); | ||
| while (!evictionThread.isEnteringRun()) { | ||
| Thread.sleep(1); |
There was a problem hiding this comment.
1 ms is nothing, let's put 1000 ms at least?
Comment on lines
90
to
92
| service.execute(new Runnable() { | ||
| @Override | ||
| public void run() { |
There was a problem hiding this comment.
Replace with lambda?
service.execute(() -> {
for (int blockIndex = 0; blockIndex < blocksPerThread
|| (!cache.isEvictionInProgress()); ++blockIndex) {
...
...
| assertEquals(cache.getOverhead(), cache.getCurrentSize()); | ||
| } | ||
| } | ||
| @Test |
There was a problem hiding this comment.
nit: leave one line b/ two methods? :)
|
|
||
| LruAdaptiveBlockCache cache = new LruAdaptiveBlockCache(maxSize,blockSize); | ||
| EvictionThread evictionThread = cache.getEvictionThread(); | ||
| assertTrue(evictionThread != null); |
There was a problem hiding this comment.
nit: assertNotNull(evictionThread)
Comment on lines
+187
to
+188
| assertTrue(cache.getBlock(block.cacheKey, true, false, | ||
| true) == null); |
There was a problem hiding this comment.
nit: assertNull(cache.getBlock(block.cacheKey, true, false, true));
…BASE-23887-LRU-Adaptive
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
Feb 13, 2021
Signed-off-by: Viraj Jasani <[email protected]>
virajjasani
pushed a commit
that referenced
this pull request
Feb 13, 2021
Signed-off-by: Viraj Jasani <[email protected]>
ddupg
pushed a commit
to ddupg/hbase
that referenced
this pull request
Feb 19, 2021
Signed-off-by: Viraj Jasani <[email protected]>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
Feb 24, 2021
Signed-off-by: Viraj Jasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #1257 (there were some problems with rebase)