HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error #2884

zhengzhuobinzzb · 2021-01-15T02:20:40Z

fix bug: string out of bounds when construct illegal tablename error

Apache-HBase · 2021-01-15T02:49:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 33s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	shadedjars	6m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	0m 28s	the patch passed
+1 💚	javac	0m 28s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 35s	hbase-common in the patch passed.
		27m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1e140ee35abe 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3cc2468`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/testReport/
Max. process+thread count	278 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-15T02:50:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	shadedjars	7m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 20s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	7m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 32s	hbase-common in the patch passed.
		28m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3d61f1641492 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3cc2468`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/testReport/
Max. process+thread count	229 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-15T02:58:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	0m 52s	master passed
+1 💚	checkstyle	0m 24s	master passed
+1 💚	spotbugs	0m 43s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	compile	0m 48s	the patch passed
+1 💚	javac	0m 48s	the patch passed
+1 💚	checkstyle	0m 24s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 51s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	0m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		37m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux aa9c725a63ef 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3cc2468`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

saintstack · 2021-01-15T04:41:35Z

Patch looks good but please file an accompanying JIRA over here https://issues.apache.org/jira/projects/HBASE/summary

After filing JIRA, please change the subject on this PR and make it the JIRA ID followed by the JIRA summary: e.g. HBASE-XXXXX string out of bounds when construct illegal tablename error Thanks.

zhengzhuobinzzb · 2021-01-15T04:48:35Z

OK, I will do this latter

zhengzhuobinzzb · 2021-01-15T08:07:26Z

Patch looks good but please file an accompanying JIRA over here https://issues.apache.org/jira/projects/HBASE/summary

After filing JIRA, please change the subject on this PR and make it the JIRA ID followed by the JIRA summary: e.g. HBASE-XXXXX string out of bounds when construct illegal tablename error Thanks.

Done. Create JIRA and link to this.
JIRA: https://issues.apache.org/jira/browse/HBASE-25512

saintstack · 2021-01-15T20:47:02Z

hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java

      throw new IllegalArgumentException(isSnapshot ? "Snapshot" : "Table" + " qualifier must not be empty");
    }
+    // Treat the bytes as UTF-8
+    String qualifierString = new String(


nit: Why do this 'new String' instead of doing Bytes.toString(qualifierName, start, end - start) ?

I fixed the summary.

Thanks!!!
No special reason here. Just copy the origin code.
Now I changed code to use Bytes.toString(qualifierName, start, end - start) instead of new String.
Is this better?

Apache-HBase · 2021-01-15T21:44:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 47s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	shadedjars	6m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 33s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	shadedjars	6m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 25s	hbase-common in the patch passed.
		25m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f864e631811a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1474ebc`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/testReport/
Max. process+thread count	340 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-15T21:46:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 30s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	6m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 8s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	6m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 36s	hbase-common in the patch passed.
		27m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 33773db7af99 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1474ebc`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/testReport/
Max. process+thread count	273 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-15T21:55:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	0m 52s	master passed
+1 💚	checkstyle	0m 26s	master passed
+1 💚	spotbugs	0m 47s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	checkstyle	0m 24s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	0m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		37m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d5deba326225 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1474ebc`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-01-30T06:39:43Z

Thanks for the PR @zhengzhuobinzzb , do you think you can add a test case for this change?

…message

Apache-HBase · 2021-02-05T11:33:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 30s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	shadedjars	7m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	shadedjars	7m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 42s	hbase-common in the patch passed.
		28m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ee1a9c888f9d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3043796`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/testReport/
Max. process+thread count	222 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-05T11:36:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 24s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	6m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 12s	the patch passed
+1 💚	compile	0m 25s	the patch passed
+1 💚	javac	0m 25s	the patch passed
+1 💚	shadedjars	6m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-common in the patch passed.
		27m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 013caa20f942 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3043796`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/testReport/
Max. process+thread count	281 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-02-05T11:46:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 25s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	checkstyle	0m 24s	master passed
+1 💚	spotbugs	0m 50s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	0m 53s	the patch passed
+1 💚	javac	0m 53s	the patch passed
+1 💚	checkstyle	0m 24s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 2s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	0m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		43m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2884
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 7a13d95ee334 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3043796`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2884/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

zhengzhuobinzzb · 2021-02-07T01:59:43Z

Thanks for the PR @zhengzhuobinzzb , do you think you can add a test case for this change?

I added it by assert this method must throw IllegalArgumentException when the table name is illegal.

…message (#2884) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>

…e error message (#2884)" This reverts commit 098f7c0.

…illegal tablename error #2884 This revert of a revert reapplies the PR; the original application was missing the HBASE JIRA #; thats why it was reverted and then reapplied w/ the JIRA # added. This reverts commit 16fe1e9.

…e error message (#2884)" This reverts commit 9b6c135.

…message (apache#2884) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>

…e error message (apache#2884)" This reverts commit 098f7c0.

…illegal tablename error apache#2884 This revert of a revert reapplies the PR; the original application was missing the HBASE JIRA #; thats why it was reverted and then reapplied w/ the JIRA # added. This reverts commit 16fe1e9.

…message (apache#2884) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>

…e error message (apache#2884)" This reverts commit 098f7c0.

…illegal tablename error apache#2884 This revert of a revert reapplies the PR; the original application was missing the HBASE JIRA #; thats why it was reverted and then reapplied w/ the JIRA # added. This reverts commit 16fe1e9.

zhengzhuobinzzb changed the title ~~fix bug: string out of bounds when construct illegal tablename error …~~ HBASE-25512 string out of bounds when construct illegal tablename error Jan 15, 2021

saintstack changed the title ~~HBASE-25512 string out of bounds when construct illegal tablename error~~ HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error Jan 15, 2021

saintstack reviewed Jan 15, 2021

View reviewed changes

zhengzhuobinzzb force-pushed the illegal-tablename-error-message-opt branch from c877135 to e869f89 Compare January 15, 2021 21:17

fix bug: string out of bounds when construct illegal tablename error …

15426af

…message

zhengzhuobinzzb force-pushed the illegal-tablename-error-message-opt branch from e869f89 to 15426af Compare February 5, 2021 10:35

saintstack merged commit 098f7c0 into apache:master Feb 8, 2021

saintstack pushed a commit that referenced this pull request Feb 8, 2021

fix bug: string out of bounds when construct illegal tablename error …

9b6c135

…message (#2884) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>

saintstack added a commit that referenced this pull request Feb 8, 2021

Revert "fix bug: string out of bounds when construct illegal tablenam…

16fe1e9

…e error message (#2884)" This reverts commit 098f7c0.

saintstack added a commit that referenced this pull request Feb 8, 2021

Revert "fix bug: string out of bounds when construct illegal tablenam…

1d281ef

…e error message (#2884)" This reverts commit 9b6c135.

ddupg pushed a commit to ddupg/hbase that referenced this pull request Feb 9, 2021

fix bug: string out of bounds when construct illegal tablename error …

300134c

…message (apache#2884) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>

ddupg pushed a commit to ddupg/hbase that referenced this pull request Feb 9, 2021

Revert "fix bug: string out of bounds when construct illegal tablenam…

9351865

…e error message (apache#2884)" This reverts commit 098f7c0.

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Feb 24, 2021

fix bug: string out of bounds when construct illegal tablename error …

e24c7ff

…message (apache#2884) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: stack <[email protected]>

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Feb 24, 2021

Revert "fix bug: string out of bounds when construct illegal tablenam…

dc9bda6

…e error message (apache#2884)" This reverts commit 098f7c0.

HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error #2884

HBASE-25512 May throw StringIndexOutOfBoundsException when construct illegal tablename error #2884

Uh oh!

Conversation

zhengzhuobinzzb commented Jan 15, 2021

Uh oh!

Apache-HBase commented Jan 15, 2021

Uh oh!

Apache-HBase commented Jan 15, 2021

Uh oh!

Apache-HBase commented Jan 15, 2021

Uh oh!

saintstack commented Jan 15, 2021

Uh oh!

zhengzhuobinzzb commented Jan 15, 2021

Uh oh!

zhengzhuobinzzb commented Jan 15, 2021

Uh oh!

saintstack Jan 15, 2021

Choose a reason for hiding this comment

Uh oh!

zhengzhuobinzzb Jan 15, 2021

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jan 15, 2021

Uh oh!

Apache-HBase commented Jan 15, 2021

Uh oh!

Apache-HBase commented Jan 15, 2021

Uh oh!

virajjasani commented Jan 30, 2021

Uh oh!

Apache-HBase commented Feb 5, 2021

Uh oh!

Apache-HBase commented Feb 5, 2021

Uh oh!

Apache-HBase commented Feb 5, 2021

Uh oh!

zhengzhuobinzzb commented Feb 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants