-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-22491 Separate the heap HFileBlock and offheap HFileBlock because the heap block won't need refCnt and save into prevBlocks list before shipping #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ExclusiveMemHFileBlock.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.io.hfile; | ||
|
|
||
| import org.apache.hadoop.hbase.io.ByteBuffAllocator; | ||
| import org.apache.hadoop.hbase.nio.ByteBuff; | ||
| import org.apache.yetus.audience.InterfaceAudience; | ||
|
|
||
| /** | ||
| * The {@link ByteBuffAllocator} won't allocate pooled heap {@link ByteBuff} now; at the same time, | ||
| * if allocate an off-heap {@link ByteBuff} from allocator, then it must be a pooled one. That's to | ||
| * say, an exclusive memory HFileBlock would must be an heap block and a shared memory HFileBlock | ||
| * would must be an off-heap block. | ||
| * <p> | ||
| * The exclusive memory HFileBlock will do nothing when calling retain or release methods, because | ||
| * its memory will be garbage collected by JVM, even if its reference count decrease to zero, we can | ||
| * do nothing for the de-allocating. | ||
| * <p> | ||
| * @see org.apache.hadoop.hbase.io.hfile.SharedMemHFileBlock | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public class ExclusiveMemHFileBlock extends HFileBlock { | ||
|
|
||
| ExclusiveMemHFileBlock(BlockType blockType, int onDiskSizeWithoutHeader, | ||
| int uncompressedSizeWithoutHeader, long prevBlockOffset, ByteBuff buf, boolean fillHeader, | ||
| long offset, int nextBlockOnDiskSize, int onDiskDataSizeWithHeader, | ||
| HFileContext fileContext) { | ||
| super(blockType, onDiskSizeWithoutHeader, uncompressedSizeWithoutHeader, prevBlockOffset, buf, | ||
| fillHeader, offset, nextBlockOnDiskSize, onDiskDataSizeWithHeader, fileContext, | ||
| ByteBuffAllocator.HEAP); | ||
| } | ||
|
|
||
| @Override | ||
| public int refCnt() { | ||
| return 0; | ||
| } | ||
|
|
||
| @Override | ||
| public ExclusiveMemHFileBlock retain() { | ||
| // do nothing | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean release() { | ||
| // do nothing | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isSharedMem() { | ||
| return false; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still we create HFileBlock only in tests? If not we could have left this API abstract only and even HFileBlock. That would have been best. May be in a follow up we can do that. Just renaming will be enough. In this jira keep it this way only. Fine.