HBASE-22335 do add hfile ref only when replication_scope is 1 #203

chenxu14 · 2019-04-30T04:23:43Z

When bulkload replication enabled, every hfile's znode will add to /hbase/replication/hfile-refs, no matter what the REPLICATION_SCOPE is.

sync master branch

Apache-HBase · 2019-04-30T09:35:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	47	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	254	master passed
+1	compile	56	master passed
+1	checkstyle	68	master passed
+1	shadedjars	267	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	227	master passed
+1	javadoc	34	master passed
		_ Patch Compile Tests _
+1	mvninstall	246	the patch passed
+1	compile	55	the patch passed
+1	javac	55	the patch passed
+1	checkstyle	68	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	273	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	502	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	229	the patch passed
+1	javadoc	32	the patch passed
		_ Other Tests _
-1	unit	16165	hbase-server in the patch failed.
+1	asflicense	61	The patch does not generate ASF License warnings.
		18660

Reason	Tests
Failed junit tests	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.quotas.TestSpaceQuotas
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/1/artifact/out/Dockerfile
GITHUB PR	#203
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ffcc1c450236 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `f9f6354`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/1/testReport/
Max. process+thread count	5075 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-05-10T14:03:29Z

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

        getCoprocessors().contains(ReplicationObserver.class.getSimpleName()));
  }

+  @Test 


whitespace:end of line

leaving feadback on the PR lines instead of making someone dig into the reporting worked! oh man that's great.

It's only whitespace I think... It will be good if we could also make findbugs and checkstyle work like this...

Apache-HBase · 2019-05-10T14:03:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	274	master passed
+1	compile	55	master passed
+1	checkstyle	71	master passed
+1	shadedjars	273	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	191	master passed
+1	javadoc	35	master passed
		_ Patch Compile Tests _
+1	mvninstall	251	the patch passed
+1	compile	55	the patch passed
+1	javac	55	the patch passed
-1	checkstyle	70	hbase-server: The patch generated 3 new + 31 unchanged - 0 fixed = 34 total (was 31)
-1	whitespace	0	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	shadedjars	271	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	542	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	244	the patch passed
+1	javadoc	35	the patch passed
		_ Other Tests _
-1	unit	16621	hbase-server in the patch failed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		19129

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.replication.TestReplicationAdminWithClusters
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.client.TestSnapshotTemporaryDirectory

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/2/artifact/out/Dockerfile
GITHUB PR	#203
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 64b83a022696 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `420fbba`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/2/artifact/out/diff-checkstyle-hbase-server.txt
whitespace	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/2/artifact/out/whitespace-eol.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/2/testReport/
Max. process+thread count	5186 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-05-13T12:12:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	52	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	257	master passed
+1	compile	49	master passed
+1	checkstyle	64	master passed
+1	shadedjars	262	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	189	master passed
+1	javadoc	32	master passed
		_ Patch Compile Tests _
+1	mvninstall	236	the patch passed
+1	compile	52	the patch passed
+1	javac	52	the patch passed
+1	checkstyle	67	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	262	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	479	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	193	the patch passed
+1	javadoc	33	the patch passed
		_ Other Tests _
-1	unit	16521	hbase-server in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		18862

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.master.procedure.TestSCPWithReplicas
	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/3/artifact/out/Dockerfile
GITHUB PR	#203
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 971ab43678ca 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `62ad94c`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/3/testReport/
Max. process+thread count	4880 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-203/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

saintstack · 2019-06-07T05:26:15Z

@chenxu14 You up for fixing the conflict when you get a chance? Thanks.

saintstack · 2019-06-24T18:32:27Z

I'll close this PR in the next week or so unless updates. Thanks.

Apache9 · 2019-07-23T14:18:33Z

Close since the PR is stale. Feel free to reopen.

chenxu14 and others added 2 commits April 30, 2019 11:32

Merge pull request #1 from apache/master

6ad0a40

sync master branch

HBASE-22335 do add hfile ref only when replication_scope is 1

c9d6eac

This was referenced Apr 30, 2019

HBASE-22277 Removed deprecated methods from Get #173

Merged

HBASE-20494 Updated the version of metrics-core to 3.2.6 #120

Merged

HBASE-22271 Implement grant/revoke/delete table acls/delete namespace acls in Procedure #168

Closed

HBASE-22335 addendum

a69644b

Apache-HBase reviewed May 10, 2019

View reviewed changes

HBASE-22335 fix checkstyle and whitespace

c014321

Apache-HBase mentioned this pull request May 15, 2019

HBASE-22275 Removed deprecated getRegionInfo in HRegionLocation #170

Merged

Apache9 closed this Jul 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

HBASE-22335 do add hfile ref only when replication_scope is 1 #203

HBASE-22335 do add hfile ref only when replication_scope is 1 #203

Uh oh!

chenxu14 commented Apr 30, 2019

Uh oh!

Apache-HBase commented Apr 30, 2019

Uh oh!

Apache-HBase May 10, 2019

Uh oh!

busbey May 10, 2019

Uh oh!

Apache9 May 10, 2019

Uh oh!

Apache-HBase commented May 10, 2019

Uh oh!

Apache-HBase commented May 13, 2019

Uh oh!

saintstack commented Jun 7, 2019

Uh oh!

saintstack commented Jun 24, 2019

Uh oh!

Apache9 commented Jul 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

HBASE-22335 do add hfile ref only when replication_scope is 1 #203

HBASE-22335 do add hfile ref only when replication_scope is 1 #203

Uh oh!

Conversation

chenxu14 commented Apr 30, 2019

Uh oh!

Apache-HBase commented Apr 30, 2019

Uh oh!

Apache-HBase May 10, 2019

Choose a reason for hiding this comment

Uh oh!

busbey May 10, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9 May 10, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 10, 2019

Uh oh!

Apache-HBase commented May 13, 2019

Uh oh!

saintstack commented Jun 7, 2019

Uh oh!

saintstack commented Jun 24, 2019

Uh oh!

Apache9 commented Jul 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants