- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.4k
HBASE-22280 Separate read/write handler for priority request(especial… #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 💔 -1 overall 
 This message was automatically generated. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new UT case to cover MetaRWQueueRpcExecutor
        
          
                hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetaRWQueueRpcExecutor.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetaRWQueueRpcExecutor.java
          
            Show resolved
            Hide resolved
        
              
          
                hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetaRWQueueRpcExecutor.java
          
            Show resolved
            Hide resolved
        
      | Please also check the  | 
| 💔 -1 overall 
 This message was automatically generated. | 
| Any updates here @binlijin ? Thanks. | 
| @saintstack i am sorry that i can not do the contribution now for some reason, someone else can take it over. | 
| 💔 -1 overall 
 This message was automatically generated. | 
| 💔 -1 overall 
 This message was automatically generated. | 
| 💔 -1 overall 
 This message was automatically generated. | 
| 💔 -1 overall 
 This message was automatically generated. | 
| 💔 -1 overall 
 This message was automatically generated. | 
| 💔 -1 overall 
 This message was automatically generated. | 
| 💔 -1 overall 
 This message was automatically generated. | 
| 💔 -1 overall 
 
 
 This message was automatically generated. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the UT result we could see below error:
[ERROR] Failures:
[ERROR] TestReportOnlineRegionsRace.testRace:167 Waiting timed out after [10,000] msec
[ERROR] Errors:
[ERROR] TestReportOnlineRegionsRace.setUp:130 » TimeoutIO java.util.concurrent.Timeout...
I checked in local environment and reproduced the error, and there's no such issue if we revert the commit of this PR, so this is a regression must be fixed.
| @carp84 fix the ut, the test need at least two write handler when use separate read/write handlers. | 
| 💔 -1 overall 
 
 
 This message was automatically generated. | 
| From the latest UT result I could see below failure/error, please double check whether they're related to changes here @binlijin . Thanks. 
 | 
| @carp84 run this tests and passed locally, they're not related to the patch. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the confirmation, then everything LGTM, +1.
#202) Signed-off-by: Yu Li <[email protected]>
#202) Signed-off-by: Yu Li <[email protected]>
…ly for meta).