HBASE-22036 Rewrite TestScannerHeartbeatMessages #191

Apache9 · 2019-04-25T10:21:23Z

Introduced a ScanPerNextResultScanner to simulate the ResultScanner in the old time.

Apache-HBase · 2019-04-25T14:56:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-21512 Compile Tests _
+1	mvninstall	264	HBASE-21512 passed
+1	compile	53	HBASE-21512 passed
+1	checkstyle	70	HBASE-21512 passed
+1	shadedjars	260	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	223	HBASE-21512 passed
+1	javadoc	33	HBASE-21512 passed
		_ Patch Compile Tests _
+1	mvninstall	255	the patch passed
+1	compile	55	the patch passed
+1	javac	55	the patch passed
+1	checkstyle	67	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	276	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	494	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	225	the patch passed
+1	javadoc	31	the patch passed
		_ Other Tests _
-1	unit	14001	hbase-server in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		16458

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/1/artifact/out/Dockerfile
GITHUB PR	#191
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 05c2201433f9 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `1465841`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/1/testReport/
Max. process+thread count	5010 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-04-26T05:35:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	21	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-21512 Compile Tests _
+1	mvninstall	257	HBASE-21512 passed
+1	compile	57	HBASE-21512 passed
+1	checkstyle	75	HBASE-21512 passed
+1	shadedjars	275	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	274	HBASE-21512 passed
+1	javadoc	40	HBASE-21512 passed
		_ Patch Compile Tests _
+1	mvninstall	266	the patch passed
-1	compile	32	hbase-server in the patch failed.
-1	javac	32	hbase-server in the patch failed.
+1	checkstyle	73	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	279	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	546	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	257	the patch passed
-1	javadoc	33	hbase-server generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
		_ Other Tests _
-1	unit	36	hbase-server in the patch failed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		2606

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/2/artifact/out/Dockerfile
GITHUB PR	#191
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e43c2fdbab7c 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul 13 08:53:17 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `dfa4f47`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
compile	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/2/artifact/out/patch-compile-hbase-server.txt
javac	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/2/artifact/out/patch-compile-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/2/artifact/out/diff-javadoc-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/2/testReport/
Max. process+thread count	86 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-04-26T12:40:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	290	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-21512 Compile Tests _
+1	mvninstall	327	HBASE-21512 passed
+1	compile	68	HBASE-21512 passed
+1	checkstyle	80	HBASE-21512 passed
+1	shadedjars	347	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	296	HBASE-21512 passed
+1	javadoc	41	HBASE-21512 passed
		_ Patch Compile Tests _
+1	mvninstall	306	the patch passed
+1	compile	69	the patch passed
+1	javac	69	the patch passed
+1	checkstyle	85	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	332	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	685	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	320	the patch passed
+1	javadoc	44	the patch passed
		_ Other Tests _
+1	unit	14937	hbase-server in the patch passed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		18338

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/3/artifact/out/Dockerfile
GITHUB PR	#191
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3b6e3628cced 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `dfa4f47`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/3/testReport/
Max. process+thread count	4761 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-191/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

openinx · 2019-04-28T02:13:44Z

hbase-server/src/test/java/org/apache/hadoop/hbase/client/ScanPerNextResultScanner.java

+ * background.
+ */
+@InterfaceAudience.Private
+public class ScanPerNextResultScanner implements ResultScanner, AdvancedScanResultConsumer {


Seems this class is only used for testing ? I prefer to move this into test package, or other future packages will use this ?

It is under the src/test/java?

OK, my bad..

asfgit force-pushed the HBASE-21512 branch from 1465841 to e2c5674 Compare April 25, 2019 14:45

asfgit force-pushed the HBASE-21512 branch from 792f69e to dfa4f47 Compare April 26, 2019 03:48

Apache9 force-pushed the HBASE-22036 branch from 9df8458 to 66e065b Compare April 26, 2019 04:04

Apache9 requested a review from infraio April 26, 2019 04:04

HBASE-22036 Rewrite TestScannerHeartbeatMessages

c5c9d7e

Apache9 force-pushed the HBASE-22036 branch from 66e065b to c5c9d7e Compare April 26, 2019 07:34

openinx reviewed Apr 28, 2019

View reviewed changes

openinx approved these changes Apr 28, 2019

View reviewed changes

Apache9 merged commit cfdbbbc into apache:HBASE-21512 Apr 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

HBASE-22036 Rewrite TestScannerHeartbeatMessages #191

HBASE-22036 Rewrite TestScannerHeartbeatMessages #191

Uh oh!

Apache9 commented Apr 25, 2019

Uh oh!

Apache-HBase commented Apr 25, 2019

Uh oh!

Apache-HBase commented Apr 26, 2019

Uh oh!

Apache-HBase commented Apr 26, 2019

Uh oh!

openinx Apr 28, 2019

Uh oh!

Apache9 Apr 28, 2019

Uh oh!

openinx Apr 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

HBASE-22036 Rewrite TestScannerHeartbeatMessages #191

HBASE-22036 Rewrite TestScannerHeartbeatMessages #191

Uh oh!

Conversation

Apache9 commented Apr 25, 2019

Uh oh!

Apache-HBase commented Apr 25, 2019

Uh oh!

Apache-HBase commented Apr 26, 2019

Uh oh!

Apache-HBase commented Apr 26, 2019

Uh oh!

openinx Apr 28, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9 Apr 28, 2019

Choose a reason for hiding this comment

Uh oh!

openinx Apr 28, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants