Skip to content

HBASE-24051 Allows indirect inheritance to CanUnbuffer #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2020
Merged

HBASE-24051 Allows indirect inheritance to CanUnbuffer #1406

merged 3 commits into from
Apr 1, 2020

Conversation

@shenshengli
Copy link
Contributor

If you have an inherited parent class that implements CanUnbuffer instead of directly implementing CanUnbuffer, you cannot get unbuffer.Differences between the old and new methods can be found in UT.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 6m 0s master passed
+1 💚 checkstyle 1m 15s master passed
+1 💚 spotbugs 2m 13s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 32s the patch passed
-0 ⚠️ checkstyle 1m 15s hbase-server: The patch generated 39 new + 7 unchanged - 0 fixed = 46 total (was 7)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 42s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 2m 19s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
38m 52s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1406
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 06a53b322a31 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 52c1013
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 83 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 34s master passed
+1 💚 compile 0m 57s master passed
+1 💚 shadedjars 4m 48s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 28s the patch passed
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 shadedjars 5m 11s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 35s the patch passed
_ Other Tests _
-1 ❌ unit 110m 49s hbase-server in the patch failed.
138m 10s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1406
Optional Tests javac javadoc unit shadedjars compile
uname Linux b14206d596f8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 52c1013
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/testReport/
Max. process+thread count 4917 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 6m 28s master passed
+1 💚 compile 1m 10s master passed
+1 💚 shadedjars 5m 41s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 43s hbase-server in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 6m 42s the patch passed
+1 💚 compile 1m 12s the patch passed
+1 💚 javac 1m 12s the patch passed
+1 💚 shadedjars 7m 15s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 1m 3s hbase-server in the patch failed.
_ Other Tests _
-0 ⚠️ unit 112m 32s hbase-server in the patch failed.
145m 45s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1406
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8958c538465b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 52c1013
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/testReport/
Max. process+thread count 5170 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1406/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@saintstack saintstack mentioned this pull request Apr 1, 2020
Closed
@saintstack saintstack merged commit ae1f928 into apache:master Apr 1, 2020
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@shenshengli @saintstack
HBASE-24051 Allows indirect inheritance to CanUnbuffer (#1406)
30f5852 
Signed-off-by: stack <[email protected]>
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@shenshengli @saintstack
HBASE-24051 Allows indirect inheritance to CanUnbuffer (#1406)
34aca94 
Signed-off-by: stack <[email protected]>
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@shenshengli @saintstack
HBASE-24051 Allows indirect inheritance to CanUnbuffer (#1406)
b9a5375 
Signed-off-by: stack <[email protected]>
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@saintstack
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (#1406)"
0914168 
This reverts commit 30f5852.
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@saintstack
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (#1406)"
e632739 
This reverts commit 34aca94.
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@saintstack
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (#1406)"
554678e 
This reverts commit ae1f928.
asfgit pushed a commit that referenced this pull request Apr 1, 2020
@saintstack
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (#1406)"
d4067c5 
This reverts commit b9a5375.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@shenshengli @thangTang
HBASE-24051 Allows indirect inheritance to CanUnbuffer (apache#1406)
90b996e 
Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack @thangTang
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (apach…
578a5df 
…e#1406)"

This reverts commit ae1f928.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@shenshengli @thangTang
HBASE-24051 Allows indirect inheritance to CanUnbuffer (apache#1406)
dca7b9d 
Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack @thangTang
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (apach…
00e19fb 
…e#1406)"

This reverts commit ae1f928.
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@shenshengli @thangTang
HBASE-24051 Allows indirect inheritance to CanUnbuffer (apache#1406)
c4ca654 
Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@saintstack @thangTang
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (apach…
0b6cb6e 
…e#1406)"

This reverts commit ae1f928.
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@shenshengli @petersomogyi
HBASE-24051 Allows indirect inheritance to CanUnbuffer (apache#1406)
6b2d9d8 
Signed-off-by: stack <[email protected]>
(cherry picked from commit b9a5375)

Change-Id: Ib4fb37eff68928f058a55eda3babe830164e5c74
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@saintstack @petersomogyi
Revert "HBASE-24051 Allows indirect inheritance to CanUnbuffer (apach…
79b24a4 
…e#1406)"

This reverts commit b9a5375.

(cherry picked from commit d4067c5)
Change-Id: I8b04a774b34edbf1ca70e2ff1dbde84ae0f49e2b

Change-Id: I5bed8049827b0c5107aa3b7ca8b57b198a564741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saintstack saintstack saintstack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shenshengli @Apache-HBase @saintstack