-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDDS-1678. Default image name for kubernetes examples should be ozone and not hadoop #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
The patch doesn't appear to correct docker image names in k8s yaml files. Something wrong in the pull request? |
|
💔 -1 overall
This message was automatically generated. |
|
+1 |
bshashikant
pushed a commit
to bshashikant/hadoop
that referenced
this pull request
Jul 10, 2019
… and not hadoop Closes apache#959
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the build the kubernetes example files are adjusted to use a specific docker image name.
By default it should be the apache/ozone:${VERSION} to make it possible to use the examples without any build from the release artifact. With the examples of the release artifact the user can use the latest released apache/ozone:${VERSION} from docker hub.
For development build the image can be set with -Ddocker.image (or -Dozone.docker.image with HDDS-1667).
Unfortunately -- due to a small typo -- apace/hadoop image is used by default instead of apache/ozone.
See: https://issues.apache.org/jira/browse/HDDS-1678