HDDS-1663. Add datanode to network topology cluster during node regis… #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
xiaoyuyao
reviewed
Jun 10, 2019
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
Jun 10, 2019
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
Jun 10, 2019
...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
Jun 10, 2019
| // create table mapping file | ||
| String[] hostNames = {"host1", "host2", "host3", "host4"}; | ||
| String[] IpAddress = {"1.2.3.4", "2.3.4.5", "3.4.5.6", "4.5.6.7"}; | ||
| File mapFile = File.createTempFile(getClass().getSimpleName() + |
There was a problem hiding this comment.
NIT: Can we use GenericTestUtils.getTestDir() to make sure the test file are cleaned up safely?
There was a problem hiding this comment.
This will not be an issue after using the mapping file instead of creating it on the fly.
xiaoyuyao
reviewed
Jun 10, 2019
| @@ -0,0 +1,6 @@ | |||
| 10.5.0.4 /rack1 | |||
There was a problem hiding this comment.
we may also pass the ip->location as a file and use the table mapping class like in the unit test.
There was a problem hiding this comment.
Sure. Will update the UT.
|
Whitespaces in network-config are intended to separate two columns. |
| @@ -0,0 +1,6 @@ | |||
| 10.5.0.4 /rack1 | |||
| @@ -0,0 +1,6 @@ | |||
| 10.5.0.4 /rack1 | |||
| 10.5.0.5 /rack1 | |||
| @@ -0,0 +1,6 @@ | |||
| 10.5.0.4 /rack1 | |||
| 10.5.0.5 /rack1 | |||
| 10.5.0.6 /rack1 | |||
| 10.5.0.4 /rack1 | ||
| 10.5.0.5 /rack1 | ||
| 10.5.0.6 /rack1 | ||
| 10.5.0.7 /rack2 |
|
💔 -1 overall
This message was automatically generated. |
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| 10.5.0.4 /rack1 |
| # limitations under the License. | ||
|
|
||
| 10.5.0.4 /rack1 | ||
| 10.5.0.5 /rack1 |
|
|
||
| 10.5.0.4 /rack1 | ||
| 10.5.0.5 /rack1 | ||
| 10.5.0.6 /rack1 |
| 10.5.0.4 /rack1 | ||
| 10.5.0.5 /rack1 | ||
| 10.5.0.6 /rack1 | ||
| 10.5.0.7 /rack2 |
|
💔 -1 overall
This message was automatically generated. |
|
Comments for the new build,
|
|
@xiaoyuyao thanks Xiaoyu for the review and commit. |
Fix me If I am wrong, but TestNodeReportHandler seems to be related. It's failing with NPE after this patch but not without this patch: |
bshashikant
pushed a commit
to bshashikant/hadoop
that referenced
this pull request
Jul 10, 2019
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
* Adding system messages to the stream * checkstyle fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ter.
https://issues.apache.org/jira/browse/HDDS-1663