Skip to content

Conversation

@kai33
Copy link
Contributor

@kai33 kai33 commented Jun 7, 2019

No description provided.

pingsutw and others added 2 commits June 7, 2019 10:02
Contributed by Huan-Ping Su

Change-Id: I64a94cf382f9db78b4ef49a3912f25f0d906af7c
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1144 trunk passed
+1 compile 1034 trunk passed
+1 checkstyle 42 trunk passed
+1 mvnsite 80 trunk passed
+1 shadedclient 856 branch has no errors when building and testing our client artifacts.
+1 javadoc 64 trunk passed
0 spotbugs 124 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 121 trunk passed
_ Patch Compile Tests _
+1 mvninstall 48 the patch passed
+1 compile 1149 the patch passed
+1 javac 1149 the patch passed
+1 checkstyle 43 the patch passed
+1 mvnsite 77 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 754 patch has no errors when building and testing our client artifacts.
+1 javadoc 63 the patch passed
+1 findbugs 190 the patch passed
_ Other Tests _
+1 unit 623 hadoop-common in the patch passed.
+1 asflicense 45 The patch does not generate ASF License warnings.
6459
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-921/1/artifact/out/Dockerfile
GITHUB PR #921
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e02de100d3de 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3ea4f41
Default Java 1.8.0_212
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-921/1/testReport/
Max. process+thread count 1716 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-921/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

+1, committed. Did a local recompile just to make sure

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
1. Added/removed modifiers
2. Guava optional -> java optional and removed guava from samza-elasticsearch module dependencies. Guava optional was added in https://issues.apache.org/jira/browse/SAMZA-853 but it is not clear why guava is better than default API.
3. Few code snippets are simplified

Author: strkkk <[email protected]>

Reviewers: Jagadish <[email protected]>

Closes apache#921 from strkkk/hdfs_es_kfka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants