HDFS-14535. The default 8KB buffer in requestFileDescriptors#Buffered… #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OutputStream is causing lots of heap allocation in HBase when using short-circut read
|
💔 -1 overall
This message was automatically generated. |
|
No new tests seems fine since this is just a small perf optimization. +1. |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…izer (apache#899) * Update ZkClient in samza-standalone to use string serialization. Changes: * Switch from using SerializableSerializer to ZkSerializer. ZkClient uses pluggable serde to serialize/deserialize user-defined types to bytes before it's written to zookeeper. In the current implementation, the predefined SerializableSerializer(which uses the java native serialization) provided as default by the ZkClient library is used by samza-standalone. SerializableSerializer auguments special characters on top of the serialized data as the auxillary data. The presence of these special characters makes the parsing zookeeper data impossible when building custom tools in languages(such as python) that does not have java native serializer. To solve this problem, this patch in introduces string serializer to serialize/deserialize data before it's written to zookeeper. * Adds a new string serializer which implements the ZkSerializer serialization abstraction provided by the ZkClient. * Fix usages where direct type conversion where done. Testing: * Added unit tests for the newly introduced serializer. * Integration testing done with the sample standalone test jobs from samza-hello-samza. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…OutputStream is causing lots of heap allocation in HBase when using short-circut read