Skip to content

Conversation

@bshashikant
Copy link
Contributor

No description provided.

@bshashikant bshashikant requested review from jnp and mukul1987 May 15, 2019 05:51
Copy link
Contributor

@mukul1987 mukul1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, the changes look good to me.

@bshashikant bshashikant changed the title Disable the sync flag by default during chunk writes in Datanode. HDDS-1531. Disable the sync flag by default during chunk writes in Datanode. May 15, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 410 trunk passed
+1 compile 197 trunk passed
+1 checkstyle 51 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 901 branch has no errors when building and testing our client artifacts.
+1 javadoc 120 trunk passed
0 spotbugs 240 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 424 trunk passed
_ Patch Compile Tests _
+1 mvninstall 398 the patch passed
+1 compile 201 the patch passed
+1 javac 201 the patch passed
+1 checkstyle 56 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 715 patch has no errors when building and testing our client artifacts.
+1 javadoc 121 the patch passed
+1 findbugs 443 the patch passed
_ Other Tests _
-1 unit 149 hadoop-hdds in the patch failed.
-1 unit 1219 hadoop-ozone in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
5621
Reason Tests
Failed junit tests hadoop.ozone.container.TestContainerReplication
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-820/1/artifact/out/Dockerfile
GITHUB PR #820
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 4473a5d7ee5e 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 2d8282b
Default Java 1.8.0_191
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-820/1/artifact/out/patch-unit-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-820/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-820/1/testReport/
Max. process+thread count 4591 (vs. ulimit of 5500)
modules C: hadoop-hdds/common U: hadoop-hdds/common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-820/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@mukul1987
Copy link
Contributor

/retest

@bshashikant bshashikant deleted the HDDS-1531 branch May 16, 2019 13:09
asfgit pushed a commit that referenced this pull request May 16, 2019
…tanode (#820). Contributed by Shashikant Banerjee.
@bshashikant
Copy link
Contributor Author

Thanks @mukul1987 for the review. I have committed this change to trunk.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
Author: Jagadish <[email protected]>

Reviewers: Jagadish <[email protected]>

Closes apache#820 from vjagadish1989/website-reorg35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants