-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19594. (Followup) Gloablly configure surefire.failIfNoSpecifiedTests=false #7995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @slfan1989 @stoty |
Wasn't aware of this failure in the last PR, sorry for the inconvenience |
stoty
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM pending tests
slfan1989
approved these changes
Sep 24, 2025
💔 -1 overall
This message was automatically generated. |
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
older versions of surefire plugin use
failIfNoTests
while newer versions usesurefire.failIfNoSpecifiedTests
to configure whether to fail when no test cases are matched.there are a few modules use
hadoop-main
instead ofhadoop-project
as the parent, this PR moves the definition ofsurefire.failIfNoSpecifiedTests
to the top-levelhadoop-main
'spom.xml
to fix the CI failure.How was this patch tested?
Run locally.
Fails on trunk
Fixed in this PR.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?