-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11261. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy. #7946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
there are only a few classes left over, can you change them together?
|
🎊 +1 overall
This message was automatically generated. |
Thanks for the review, Pan. To keep things straightforward for the different maintainers and CI jobs, would it be okay to split this into one PR per module? The tests touch separate areas, so smaller PRs should make review and potential reverts simpler.
|
@zhtttylz +1, This suggestion makes sense. To facilitate code review and future maintenance, it's recommended to submit changes by module separately, and avoid merging changes from multiple modules in a single commit. |
I'm going to merge this PR. There are no issues with it—it works as expected. |
Description of PR
JIRA: YARN-11261. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?