Skip to content

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Sep 10, 2025

Description of PR

JIRA: YARN-11261. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@pan3793
Copy link
Member

pan3793 commented Sep 10, 2025

there are only a few classes left over, can you change them together?

$ grep -rl --include='*.java' "import org.junit.Test" . | sort | uniq
./hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/test/TestFuseDFS.java
./hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestFedAppReportFetcher.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServletFed.java

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 9m 15s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 26m 0s trunk passed
+1 💚 compile 0m 18s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 18s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 0m 19s trunk passed
+1 💚 mvnsite 0m 22s trunk passed
+1 💚 javadoc 0m 25s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 20s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 35s trunk passed
+1 💚 shadedclient 20m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 12s the patch passed
+1 💚 compile 0m 14s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 14s the patch passed
+1 💚 compile 0m 12s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 12s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 10s the patch passed
+1 💚 mvnsite 0m 15s the patch passed
+1 💚 javadoc 0m 14s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 14s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 0m 32s the patch passed
+1 💚 shadedclient 21m 2s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 1m 4s hadoop-yarn-server-web-proxy in the patch passed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
84m 28s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7946/1/artifact/out/Dockerfile
GITHUB PR #7946
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 46c7aaf5402a 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ca09fd9
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7946/1/testReport/
Max. process+thread count 626 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7946/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhtttylz
Copy link
Contributor

there are only a few classes left over, can you change them together?

$ grep -rl --include='*.java' "import org.junit.Test" . | sort | uniq
./hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/test/TestFuseDFS.java
./hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestFedAppReportFetcher.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServletFed.java

Thanks for the review, Pan. To keep things straightforward for the different maintainers and CI jobs, would it be okay to split this into one PR per module? The tests touch separate areas, so smaller PRs should make review and potential reverts simpler.
Remaining items:

• hadoop-aws: ITestS3AContractSeek, ITestTreewalkProblems
• hadoop-compat-bench: compat/cases/* (e.g., HdfsCompatAcl … HdfsCompatTpcds)
• hadoop-azure: ITestAbfsTerasort … ITestExponentialRetryPolicy
• hadoop-hdfs-native-client: TestFuseDFS
• hadoop-hdfs-rbf: TestRouterDistCpProcedure, …/server/federation/security/token/*

@slfan1989 slfan1989 marked this pull request as ready for review September 11, 2025 00:06
@slfan1989
Copy link
Contributor Author

there are only a few classes left over, can you change them together?

$ grep -rl --include='*.java' "import org.junit.Test" . | sort | uniq
./hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/test/TestFuseDFS.java
./hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestFedAppReportFetcher.java
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServletFed.java

Thanks for the review, Pan. To keep things straightforward for the different maintainers and CI jobs, would it be okay to split this into one PR per module? The tests touch separate areas, so smaller PRs should make review and potential reverts simpler. Remaining items:

• hadoop-aws: ITestS3AContractSeek, ITestTreewalkProblems
• hadoop-compat-bench: compat/cases/* (e.g., HdfsCompatAcl … HdfsCompatTpcds)
• hadoop-azure: ITestAbfsTerasort … ITestExponentialRetryPolicy
• hadoop-hdfs-native-client: TestFuseDFS
• hadoop-hdfs-rbf: TestRouterDistCpProcedure, …/server/federation/security/token/*

@zhtttylz +1, This suggestion makes sense. To facilitate code review and future maintenance, it's recommended to submit changes by module separately, and avoid merging changes from multiple modules in a single commit.

@slfan1989
Copy link
Contributor Author

I'm going to merge this PR. There are no issues with it—it works as expected.

@slfan1989 slfan1989 merged commit 183b576 into apache:trunk Sep 12, 2025
4 checks passed
@slfan1989
Copy link
Contributor Author

@pan3793 @zhtttylz Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants