Skip to content

HADOOP-19343: Include hadoop-gcp in distro. #7877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HADOOP-19343: Include hadoop-gcp in distro. #7877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion hadoop-tools/hadoop-gcp/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,6 @@
</shadedPattern>
</relocation>
</relocations>
<shadedArtifactAttached>true</shadedArtifactAttached>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two options:

  1. shadedArtifactAttached=true means a separate shaded jar artifact will be attached to the build. Clients can depend on it by specifying <classifier>shaded</classifier> in the dependency declaration.
  2. shadedArtifactAttached=false (the default, hence removed in this patch) means the shaded jar completely replaces the published artifact. I think this is what we want for hadoop-gcp, given the tight coupling to specific shaded versions of things like Guava and gRPC. There wouldn't be much value in the non-shaded artifacts.

</configuration>
</execution>
</executions>
Expand Down
6 changes: 6 additions & 0 deletions hadoop-tools/hadoop-tools-dist/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@
<scope>compile</scope>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-gcp</artifactId>
<scope>compile</scope>
<version>${project.version}</version>
</dependency>
</dependencies>

<build>
Expand Down